All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] dynamic chip support
Date: Fri, 25 May 2007 13:25:19 +0000	[thread overview]
Message-ID: <20070525152519.032dbd7c@hyperion.delvare> (raw)
In-Reply-To: <461B7F5C.5080409@hhs.nl>

On Fri, 25 May 2007 10:34:04 +0200, Hans de Goede wrote:
> I might be getting / reading this wrong, but take a look at adm1021_features
> in lib/chips.c there it still clearly states:
>      { { SENSORS_ADM1021_REMOTE_TEMP, "remote_temp", NOMAP, NOMAP, R },
>                                       ADM1021_SYSCTL_REMOTE_TEMP, VALUE(3), 0 },
>      { { SENSORS_ADM1021_REMOTE_TEMP_HYST, "remote_temp_low",
> ...
> 
> I haven't looked at the actual 2.6 driver. If the 2.6 driver indeed calls it 
> temp2_input, then how does libsensors know this??

There is a translation table for common symbol names in lib/proc.c:

static const struct match matches[] = {
	{ "beeps", "beep_mask", 0 },
	{ "pwm", "pwm1", 0, "fan1_pwm" },
	{ "vid", "cpu0_vid", INMAG, "in0_ref" },
	{ "remote_temp", "temp2_input", TEMPMAG },
	{ "remote_temp_hyst", "temp2_max_hyst", TEMPMAG },
	{ "remote_temp_low", "temp2_min", TEMPMAG },
	{ "remote_temp_over", "temp2_max", TEMPMAG },
	{ "temp", "temp1_input", TEMPMAG },
	{ "temp_hyst", "temp1_max_hyst", TEMPMAG },
	{ "temp_low", "temp1_min", TEMPMAG },
	{ "temp_over", "temp1_max", TEMPMAG },
	{ "temp_high", "temp1_max", TEMPMAG },
	{ "temp_crit", "temp1_crit", TEMPMAG },
	{ NULL, NULL }
};

Once we are done with the generic code and get rid of the chip-specific
declarations, all this symbol name translation stuff will be deleted as
well.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

      parent reply	other threads:[~2007-05-25 13:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-10 11:54 [lm-sensors] dynamic chip support Hans de Goede
2007-05-25  7:53 ` Jean Delvare
2007-05-25  8:34 ` Hans de Goede
2007-05-25 13:25 ` Jean Delvare [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070525152519.032dbd7c@hyperion.delvare \
    --to=khali@linux-fr.org \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.