From: Dave Jones <davej@redhat.com>
To: Andi Kleen <ak@novell.com>
Cc: Chuck Ebbert <cebbert@redhat.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Multiple free during oprofile unload
Date: Fri, 25 May 2007 12:18:37 -0400 [thread overview]
Message-ID: <20070525161837.GA26105@redhat.com> (raw)
In-Reply-To: <200705251742.35692.ak@novell.com>
On Fri, May 25, 2007 at 05:42:35PM +0200, Andi Kleen wrote:
>
> > for_each_possible_cpu(i) {
> > kfree(cpu_msrs[i].counters);
> > cpu_msrs[i].counters = NULL;
> > kfree(cpu_msrs[i].controls);
> > cpu_msrs[i].controls = NULL;
> > }
> >
> > Seems the patch makes all the cpu_msrs[] point to the same area?
>
> Yes I forgot to fix the free path. Will submit a patch.
>
> BTW that is why I'm not so happy with you being so trigger happy with stable
> submissions.
So what, the alternative is leave oprofile busted in 2.6.21.x even longer?
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2007-05-25 16:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-25 15:00 Multiple free during oprofile unload Chuck Ebbert
2007-05-25 15:42 ` Andi Kleen
2007-05-25 16:18 ` Dave Jones [this message]
2007-05-25 17:13 ` Andi Kleen
2007-05-25 17:38 ` Dave Jones
2007-05-25 18:02 ` Andi Kleen
2007-05-25 18:37 ` Alan Cox
2007-05-26 2:27 ` [PATCH] x86: fix oprofile double free (was Re: Multiple free during oprofile unload) Chris Wright
2007-05-26 7:43 ` Andi Kleen
2007-05-26 14:03 ` Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070525161837.GA26105@redhat.com \
--to=davej@redhat.com \
--cc=ak@novell.com \
--cc=cebbert@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.