From: Hunyue Yau <hyau@mvista.com>
To: Dmitry Krivoschekov <dmitry.krivoschekov@gmail.com>
Cc: Linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] OMAP: 2430SDP: Support LCD display as a FB device
Date: Fri, 25 May 2007 17:20:36 -0700 [thread overview]
Message-ID: <200705251720.37116.hyau@mvista.com> (raw)
In-Reply-To: <46576B90.2050508@gmail.com>
On Friday 25 May 2007 16:04, Dmitry Krivoschekov wrote:
> Hunyue Yau wrote:
> >
> > +#define TWL4030_VAUX2_DEV_GRP 0x1B
> > +#define TWL4030_VAUX2_DEDICATED 0x1E
> > +#define TWL4030_MODULE_PM_RECIEVER 0x13
> > +
> > +
> > +
>
> What's the reason to re-define this?
> It's already defined in asm/arch/twl4030.h.
>
>
> Thanks,
> Dmitry
>
Sorry, an oversight. This goes on top of the original patch. More
potential changes pending the mentioned discussions.
-- Hunyue
--- linux-omap-2.6/drivers/video/omap/lcd_2430sdp.c 2007-05-24 18:32:24.000000000 -0700
+++ linux-omap-2.6.work/drivers/video/omap/lcd_2430sdp.c 2007-05-25 16:11:10.000000000 -0700
@@ -35,11 +35,6 @@
#define PM_RECEIVER TWL4030_MODULE_PM_RECIEVER
#define ENABLE_VAUX2_DEDICATED 0x09
#define ENABLE_VAUX2_DEV_GRP 0x20
-#define TWL4030_VAUX2_DEV_GRP 0x1B
-#define TWL4030_VAUX2_DEDICATED 0x1E
-#define TWL4030_MODULE_PM_RECIEVER 0x13
-
-
#define t2_out(c, r, v) twl4030_i2c_write_u8(c, r, v)
next prev parent reply other threads:[~2007-05-26 0:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-25 22:18 [PATCH] OMAP: 2430SDP: Support LCD display as a FB device Hunyue Yau
2007-05-25 22:33 ` Tony Lindgren
2007-05-25 22:36 ` nishanth menon
2007-05-25 22:43 ` Kevin Hilman
2007-05-25 22:49 ` Tony Lindgren
2007-05-25 23:04 ` Dmitry Krivoschekov
2007-05-26 0:20 ` Hunyue Yau [this message]
2007-05-25 23:20 ` Syed Mohammed, Khasim
2007-05-25 23:42 ` Kevin Hilman
2007-05-25 23:51 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705251720.37116.hyau@mvista.com \
--to=hyau@mvista.com \
--cc=Linux-omap-open-source@linux.omap.com \
--cc=dmitry.krivoschekov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.