From: Andi Kleen <andi@firstfloor.org>
To: Daniel Walker <dwalker@mvista.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
mingo@elte.hu, andi@firstfloor.org
Subject: Re: [PATCH 1/2] non-string based tsc unstable reasons
Date: Fri, 25 May 2007 23:05:04 +0200 [thread overview]
Message-ID: <20070525210504.GD24083@one.firstfloor.org> (raw)
In-Reply-To: <20070525193209.607200255@mvista.com>
On Fri, May 25, 2007 at 12:32:10PM -0700, Daniel Walker wrote:
> Just passing a string to mark_tsc_unstable() doesn't allow real code to change
> based on the reason for the instablility. I changed mark_tsc_unstable()
> to accept a string and a flag which denotes a general reason why the tsc
> is unstable, and can be evaluated in code.
>
I still think that's the wrong way to do this. If there is any
special action that should be done on particular unstable events
it should call a separate function or an addon function.
First putting it all together and then try to distingush it again
doesn't seem nice.
-Andi
next prev parent reply other threads:[~2007-05-25 21:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-25 19:32 [PATCH 1/2] non-string based tsc unstable reasons Daniel Walker
2007-05-25 19:32 ` [PATCH 2/2] i386: sched_clock() follows percpu frequency changes -v2 Daniel Walker
2007-05-25 21:05 ` Andi Kleen [this message]
2007-05-25 21:31 ` [PATCH 1/2] non-string based tsc unstable reasons Daniel Walker
-- strict thread matches above, loose matches on Subject: below --
2007-05-12 15:43 Daniel Walker
2007-05-12 18:56 ` Andi Kleen
2007-05-12 19:10 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070525210504.GD24083@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.