From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Andreas Schwab <schwab@suse.de>
Subject: Re: [Qemu-devel] [M68K] Full extension word format addressing mode
Date: Sat, 26 May 2007 22:16:44 +0100 [thread overview]
Message-ID: <200705262216.45853.paul@codesourcery.com> (raw)
In-Reply-To: <jek5uv20ty.fsf@sykes.suse.de>
On Saturday 26 May 2007, Andreas Schwab wrote:
> This patch implements the full extension word format addressing mode in
> the m68k emulation. I have manually verified that it gets all cases
> right.
> + if ((ext & 0x80) == 0) {
> + /* base not suppressed */
> + if (base == -1)
> + tmp = gen_im32(offset + bd);
> + else if (bd != 0) {
> + tmp = gen_new_qreg(QMODE_I32);
> + gen_op_add32(tmp, base, gen_im32(bd));
> + } else
> + tmp = base;
> + if ((ext & 0x44) == 0)
> + gen_op_add32(tmp, tmp, add);
This corrupts a2 in the following instruction:
move.l ([%a2,%a1.l],0),%a0
I've fixed that and tweaked how temporary variables are used.
Paul
next prev parent reply other threads:[~2007-05-26 21:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-26 13:04 [Qemu-devel] [M68K] Full extension word format addressing mode Andreas Schwab
2007-05-26 21:16 ` Paul Brook [this message]
2007-05-26 22:44 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705262216.45853.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.