All of lore.kernel.org
 help / color / mirror / Atom feed
From: thompsy@gmail.com (thompsy)
To: kernel-janitors@vger.kernel.org
Subject: [KJ] [PATCH] arch/i386/kernel/efi.c: fixing uninitialised variable
Date: Sun, 27 May 2007 20:11:46 +0000	[thread overview]
Message-ID: <20070527201146.GA7066@dev-box> (raw)

Hello All,

I'm going to try and work through some of the gcc warnings generated from
building the kernel. I've included my first patch below but have a question
first.

Having looking in MAINTAINERS I wasn't sure who the appropriate person
would be to CC this to. The closest thing I could find was FIRMWARE LOADER
header which is listed as an orphan. In this case should I just CC to LKML?

The patch initialises the prev struct as it gets checked before being
initialised later in the code. This removes the warning generated by gcc.

Any feedback welcome.
Thanks

Signed-off-by: Andrew Thompson <thompsy@gmail.com>
---
diff --git a/arch/i386/kernel/efi.c b/arch/i386/kernel/efi.c
index a180802..8a9faeb 100644
--- a/arch/i386/kernel/efi.c
+++ b/arch/i386/kernel/efi.c
@@ -278,7 +278,7 @@ void efi_memmap_walk(efi_freemem_callbac
 	struct range {
 		unsigned long start;
 		unsigned long end;
-	} prev, curr;
+	} prev={}, curr;
 	efi_memory_desc_t *md;
 	unsigned long start, end;
 	void *p;
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

             reply	other threads:[~2007-05-27 20:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-27 20:11 thompsy [this message]
2007-05-28 12:09 ` [KJ] [PATCH] arch/i386/kernel/efi.c: fixing uninitialised variable Florian Westphal
2007-05-28 17:57 ` Andrew Thompson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070527201146.GA7066@dev-box \
    --to=thompsy@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.