From: Arnd Bergmann <arnd@arndb.de>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] replacing old-style "non-seekable" errors with "no_llseek"
Date: Sun, 27 May 2007 22:00:23 +0000 [thread overview]
Message-ID: <200705280000.23973.arnd@arndb.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0705271722580.13051@localhost.localdomain>
On Sunday 27 May 2007, Robert P. J. Day wrote:
> can be rewritten more cleanly using the no_llseek() helper routine,
> and just assigning no_llseek to the llseek member of the
> file_operations struct, as in:
>
> .llseek = no_llseek
>
> and deleting the old routine. am i reading that correctly? or is
> there more to it than that?
Actually, that is outdated as well.
If the file descriptor cannot be seeked, you should set the open
operation to nonseekable_open, or call that function from the
driver's own open function.
Arnd <><
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2007-05-27 22:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-27 21:28 [KJ] replacing old-style "non-seekable" errors with "no_llseek" Robert P. J. Day
2007-05-27 22:00 ` Arnd Bergmann [this message]
2007-05-28 17:46 ` Robert P. J. Day
2007-05-28 19:13 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705280000.23973.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.