From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763467AbXE2SAy (ORCPT ); Tue, 29 May 2007 14:00:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752609AbXE2SAq (ORCPT ); Tue, 29 May 2007 14:00:46 -0400 Received: from smtp1.linux-foundation.org ([207.189.120.13]:50525 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762596AbXE2SAp (ORCPT ); Tue, 29 May 2007 14:00:45 -0400 Date: Tue, 29 May 2007 11:00:41 -0700 From: Andrew Morton To: "Robert P. J. Day" Cc: Linux Kernel Mailing List , Alexander Viro Subject: Re: [PATCH] FILESYSTEMS: Delete unused "int dummy[5]" from inodes_stat_t. Message-Id: <20070529110041.49bf57f1.akpm@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.6; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 29 May 2007 13:11:07 -0400 (EDT) "Robert P. J. Day" wrote: > > Delete the apparently unused array "int dummy[5]" from struct > inodes_stat_t. > > Signed-off-by: Robert P. J. Day > > --- > > no idea what that array is for, but no one seems to care about it. > removal compile-tested on x86 with "make allyesconfig" and nobody > misses it (unless it's used for padding of some kind). > > > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 7cf0c54..dec83dd 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -44,7 +44,6 @@ extern int get_max_files(void); > struct inodes_stat_t { > int nr_inodes; > int nr_unused; > - int dummy[5]; > }; > extern struct inodes_stat_t inodes_stat; > kernel/sysctl.c: { .ctl_name = FS_STATINODE, .procname = "inode-state", .data = &inodes_stat, .maxlen = 7*sizeof(int), .mode = 0444, .proc_handler = &proc_dointvec, }, akpm:/home/akpm> cat /proc/sys/fs/inode-state 608039 178454 0 0 0 0 0 So it _is_ used: to present those five zeroes. I think this is for back-compatibility with some cretaceous-era kernel.