All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: andrzej zaborowski <balrogg@gmail.com>
Cc: Linux OMAP <linux-omap-open-source@linux.omap.com>
Subject: Re: [PATCH 7/11] Adding OMAP3430 support to plat-omap
Date: Tue, 29 May 2007 09:51:51 -0700	[thread overview]
Message-ID: <20070529165151.GB26322@atomide.com> (raw)
In-Reply-To: <fb249edb0705290313h1a570dabqe92f8665cb5e10ac@mail.gmail.com>

* andrzej zaborowski <balrogg@gmail.com> [070529 03:14]:
>> @@ -279,7 +279,7 @@ int __init omap_sram_init(void)
>>         omap_detect_sram();
>>         omap_map_sram();
>>
>> -       if (!cpu_is_omap24xx())
>> +       if (!(cpu_is_omap24xx() || cpu_is_omap34xx()))
>>                 omap1_sram_init();
>>         else
>>                 omap2_sram_init();
>
> Maybe omap cpu_class_is_omap2() would be more apropriate in places like 
> this?

I agree, that cuts down the if this and that clutter.

Tony

      reply	other threads:[~2007-05-29 16:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-29  6:22 [PATCH 7/11] Adding OMAP3430 support to plat-omap Syed Mohammed, Khasim
2007-05-29  6:54 ` Trilok Soni
2007-05-29 10:13 ` andrzej zaborowski
2007-05-29 16:51   ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070529165151.GB26322@atomide.com \
    --to=tony@atomide.com \
    --cc=balrogg@gmail.com \
    --cc=linux-omap-open-source@linux.omap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.