From: Andrew Morton <akpm@linux-foundation.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-m68k@vger.kernel.org,
Roman Zippel <zippel@linux-m68k.org>
Subject: Re: [patch 2/2] m68k: Discontinuous memory support
Date: Tue, 29 May 2007 17:45:56 -0700 [thread overview]
Message-ID: <20070529174556.20c551a0.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070528191715.597623909@mail.of.borg>
On Mon, 28 May 2007 21:16:32 +0200
Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> -#define __page_address(page) (PAGE_OFFSET + (((page) - mem_map) << PAGE_SHIFT))
> -#define page_to_phys(page) virt_to_phys((void *)__page_address(page))
> +#ifdef CONFIG_SINGLE_MEMORY_CHUNK
> +#define page_to_phys(page) \
> + __pa(PAGE_OFFSET + (((page) - pg_data_map[0].node_mem_map) << PAGE_SHIFT))
> +#else
> +#define page_to_phys(page) ({ \
> + struct pglist_data *pgdat; \
> + pgdat = pg_data_table[page_to_nid(page)]; \
> + page_to_pfn(page) << PAGE_SHIFT; \
> +})
> +#endif
macros which evaluate their args more than once are dangerous.
prev parent reply other threads:[~2007-05-30 0:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-28 19:16 [patch 0/2] A few more m68k patches Geert Uytterhoeven
2007-05-28 19:16 ` [patch 1/2] m68k: runtime patching infrastructure Geert Uytterhoeven
2007-05-30 0:38 ` Andrew Morton
2007-05-30 5:48 ` Eric Dumazet
2007-05-30 7:06 ` Geert Uytterhoeven
2007-05-30 8:20 ` Joerg Dorchain
2007-05-30 11:19 ` Geert Uytterhoeven
2007-05-30 11:40 ` Joerg Dorchain
2007-05-30 8:23 ` Andreas Schwab
2007-05-30 18:03 ` Linus Torvalds
2007-06-03 15:56 ` Wouter Verhelst
2007-05-28 19:16 ` [patch 2/2] m68k: Discontinuous memory support Geert Uytterhoeven
2007-05-30 0:44 ` Andrew Morton
2007-05-30 0:45 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070529174556.20c551a0.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.