All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: menage@google.com
Cc: dev@sw.ru, xemul@sw.ru, serue@us.ibm.com, vatsa@in.ibm.com,
	ebiederm@xmission.com, haveblue@us.ibm.com,
	svaidy@linux.vnet.ibm.com, balbir@in.ibm.com, pj@sgi.com,
	cpw@sgi.com, ckrm-tech@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, containers@lists.osdl.org,
	mbligh@google.com, rohitseth@google.com, devel@openvz.org
Subject: Re: [PATCH 02/10] Containers(V10): Example CPU accounting subsystem
Date: Wed, 30 May 2007 00:16:00 -0700	[thread overview]
Message-ID: <20070530001600.1d44f5b7.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070529132142.238927000@menage.corp.google.com>

On Tue, 29 May 2007 06:01:06 -0700 menage@google.com wrote:

> This example demonstrates how to use the generic container subsystem
> for a simple resource tracker that counts, for the processes in a
> container, the total CPU time used and the %CPU used in the last
> complete 10 second interval.
> 
> ...
>
> --- /dev/null
> +++ container-2.6.22-rc2-mm1/kernel/cpu_acct.c
> @@ -0,0 +1,185 @@
> +/*
> + * kernel/cpu_acct.c - CPU accounting container subsystem
> + *
> + * Copyright (C) Google Inc, 2006
> + *
> + * Developed by Paul Menage (menage@google.com) and Balbir Singh
> + * (balbir@in.ibm.com)
> + *
> + */
>
> ...
>
> +static u64 cpuusage_read(struct container *cont,
> +			 struct cftype *cft)
> +{
> +	struct cpuacct *ca = container_ca(cont);
> +	u64 time;
> +
> +	spin_lock_irq(&ca->lock);
> +	cpuusage_update(ca);
> +	time = cputime64_to_jiffies64(ca->time);
> +	spin_unlock_irq(&ca->lock);
> +
> +	/* Convert 64-bit jiffies to seconds */
> +	time *= 1000;
> +	do_div(time, HZ);

hm, we have jiffies_to_lotsofthings, but we don't appear to have a
jiffies_to_seconds.  How odd.



  reply	other threads:[~2007-05-30  7:18 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-29 13:01 [PATCH 00/10] Containers(V10): Generic Process Containers menage
2007-05-29 13:01 ` [PATCH 01/10] Containers(V10): Basic container framework menage
2007-05-30  7:15   ` Andrew Morton
2007-05-30  7:15   ` Andrew Morton
2007-05-30 14:02     ` Paul Menage
2007-05-30 16:00       ` Andrew Morton
2007-06-13 10:17   ` Dhaval Giani
2007-05-29 13:01 ` [PATCH 02/10] Containers(V10): Example CPU accounting subsystem menage
2007-05-30  7:16   ` Andrew Morton [this message]
2007-05-29 13:01 ` [PATCH 03/10] Containers(V10): Add tasks file interface menage
2007-06-07 14:00   ` Cedric Le Goater
2007-06-07 17:12     ` Paul Menage
2007-05-29 13:01 ` [PATCH 04/10] Containers(V10): Add fork/exit hooks menage
2007-05-29 13:01 ` [PATCH 05/10] Containers(V10): Add container_clone() interface menage
2007-05-30  7:16   ` Andrew Morton
2007-05-31 19:56     ` Serge E. Hallyn
2007-05-29 13:01 ` [PATCH 06/10] Containers(V10): Add procfs interface menage
2007-05-29 13:01 ` [PATCH 07/10] Containers(V10): Make cpusets a client of containers menage
2007-05-29 13:01 ` [PATCH 08/10] Containers(V10): Share css_group arrays between tasks with same container memberships menage
2007-05-29 13:01 ` [PATCH 09/10] Containers(V10): Simple debug info subsystem menage
2007-05-29 13:01 ` [PATCH 10/10] Containers(V10): Support for automatic userspace release agents menage
2007-05-30  7:14 ` [PATCH 00/10] Containers(V10): Generic Process Containers Andrew Morton
2007-05-30  7:39   ` William Lee Irwin III
2007-06-28 21:27     ` Paul Menage
2007-06-28 22:13       ` [ckrm-tech] " Srivatsa Vaddagiri
2007-05-30  8:09   ` Balbir Singh
2007-05-30  9:02     ` Pavel Emelianov
2007-05-30  9:02       ` Balbir Singh
2007-05-30 10:48 ` Pavel Emelianov
2007-06-04 19:14 ` Serge E. Hallyn
2007-06-04 19:31   ` Paul Jackson
2007-06-04 20:30     ` Paul Menage
2007-06-04 20:37       ` Paul Jackson
2007-06-04 20:41       ` Serge E. Hallyn
2007-06-04 21:05         ` Paul Jackson
2007-06-06 22:39           ` Serge E. Hallyn
2007-06-06 22:43             ` Paul Jackson
2007-06-07  0:05               ` Serge E. Hallyn
2007-06-07  0:46                 ` [ckrm-tech] " Paul Jackson
2007-06-07 18:01                   ` Serge E. Hallyn
2007-06-07 19:21                     ` Paul Jackson
2007-06-07 20:17                       ` Serge E. Hallyn
2007-06-07 22:01                         ` Paul Jackson
2007-06-08 14:32                           ` Serge E. Hallyn
2007-06-08 15:55                             ` Paul Menage
2007-06-08 16:08                               ` Serge E. Hallyn
2007-06-08 16:16                                 ` Paul Menage
2007-06-08 18:08                                   ` Serge E. Hallyn
2007-06-08 18:13                                     ` Paul Menage
2007-06-08 19:42                                       ` Serge E. Hallyn
2007-06-08 20:05                                         ` Paul Jackson
2007-06-08 17:37                             ` Paul Jackson
2007-06-04 20:32   ` Paul Menage
2007-06-04 20:51     ` Serge E. Hallyn
2007-06-04 20:56       ` Paul Menage
2007-06-04 21:11         ` Serge E. Hallyn
2007-06-04 21:16           ` Paul Jackson
2007-06-04 21:09       ` [ckrm-tech] " Paul Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070530001600.1d44f5b7.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=balbir@in.ibm.com \
    --cc=ckrm-tech@lists.sourceforge.net \
    --cc=containers@lists.osdl.org \
    --cc=cpw@sgi.com \
    --cc=dev@sw.ru \
    --cc=devel@openvz.org \
    --cc=ebiederm@xmission.com \
    --cc=haveblue@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mbligh@google.com \
    --cc=menage@google.com \
    --cc=pj@sgi.com \
    --cc=rohitseth@google.com \
    --cc=serue@us.ibm.com \
    --cc=svaidy@linux.vnet.ibm.com \
    --cc=vatsa@in.ibm.com \
    --cc=xemul@sw.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.