All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Habets <errandir_news@mph.eclipse.co.uk>
To: sparclinux@vger.kernel.org
Subject: Re: [RFT] [SPARC] Emulate cmpxchg like parisc
Date: Wed, 30 May 2007 19:38:38 +0000	[thread overview]
Message-ID: <20070530193838.GA29445@palantir8> (raw)
In-Reply-To: <20070525201143.GB14171@fattire.cabal.ca>

On Tue, May 29, 2007 at 01:59:31PM -0700, David Miller wrote:
> From: Martin Habets <errandir_news@mph.eclipse.co.uk>
> Date: Tue, 29 May 2007 21:30:45 +0100
> 
> > On Tue, May 29, 2007 at 01:12:33AM -0700, David Miller wrote:
> > > From: Martin Habets <errandir_news@mph.eclipse.co.uk>
> > > Date: Tue, 29 May 2007 00:37:01 +0100
> > > 
> > > > Good to see someone has a crystal ball handy. So a patch like like this
> > > > to solve the DRM issue? With it DRM can no longer be selected.
> > > > 
> > > > ---
> > > > The DRM code depends on an atomic version of cmpxchg(), which is not
> > > > available on sparc32. Since other platforms besides sparc32 have
> > > > this issue a KCONFIG option is added for it.
> > > > 
> > > > Martin
> > > > 
> > > > 	Signed-off-by: Martin Habets <errandir_news@mph.eclipse.co.uk>
> > > 
> > > This looks great, I've applied Kyle's original patch and this
> > > one, thanks a lot!
> > 
> > Ehh, Kyle's original patch did not build. See my initial reply to that
> > one, which has a version that does build cleanly.
> 
> I fixed his version to build and more match the types of the
> parisc code when I chekced it in.

I also got a build error on 'addr' in __cmpxchg_u32(). Changed those
to 'ptr'.
Maybe I've just got an -Wextra-dumb switch on my cc, or you've got
a -Wpsychic :).

-- 
Martin

      parent reply	other threads:[~2007-05-30 19:38 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-25 20:11 [RFT] [SPARC] Emulate cmpxchg like parisc Kyle McMartin
2007-05-26  0:24 ` Martin Habets
2007-05-26  5:00 ` David Miller
2007-05-26  5:14 ` Tom "spot" Callaway
2007-05-26 14:45 ` Kyle McMartin
2007-05-26 19:39 ` Martin Habets
2007-05-26 20:32 ` Dave Airlie
2007-05-26 22:46 ` David Miller
2007-05-26 22:59 ` David Miller
2007-05-26 23:00 ` David Miller
2007-05-26 23:41 ` Kyle McMartin
2007-05-27  0:04 ` David Miller
2007-05-28  0:07 ` Martin Habets
2007-05-28  2:49 ` David Miller
2007-05-28  3:11 ` Kyle McMartin
2007-05-28  3:16 ` David Miller
2007-05-28 23:37 ` Martin Habets
2007-05-29  8:12 ` David Miller
2007-05-29 13:18 ` Kyle McMartin
2007-05-29 20:30 ` Martin Habets
2007-05-29 20:59 ` David Miller
2007-05-29 21:08 ` Kyle McMartin
2007-05-30 19:38 ` Martin Habets [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070530193838.GA29445@palantir8 \
    --to=errandir_news@mph.eclipse.co.uk \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.