From: David Miller <davem@davemloft.net>
To: mchan@broadcom.com
Cc: netdev@vger.kernel.org
Subject: Re: [TG3]: Fix link problem on Dell's onboard 5906.
Date: Thu, 31 May 2007 14:50:24 -0700 (PDT) [thread overview]
Message-ID: <20070531.145024.52169518.davem@davemloft.net> (raw)
In-Reply-To: <1180649019.20882.3.camel@dell>
From: "Michael Chan" <mchan@broadcom.com>
Date: Thu, 31 May 2007 15:03:39 -0700
> [TG3]: Fix link problem on Dell's onboard 5906.
>
> The bug is caused by code that always set
> (TG3_FLAG_USE_MI_INTERRUPT | TG3_FLAG_USE_LINKCHG_REG) on all Dell's
> onboard devices. With these 2 flags set, the link status is polled
> by tg3_timer() and will only work when the PHY is set up to interrupt
> the MAC on link changes. This breaks 5906 because the 5906 PHY does
> not support TG3_FLAG_USE_MI_INTERRUPT the same as other PHYs.
>
> For correctness, only Dell's onboard 5701 needs these 2 flags to be
> set. This change will fix the 5906 problem and will change other
> Dell devices except 5700 and 5701 to use the more efficient
> interrupt-driven link changes.
>
> Update version to 3.77.
>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Patch applied, thanks for fixing this bug Michael.
That Dell onboard chip logic is definitely my fault :)
prev parent reply other threads:[~2007-05-31 21:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-31 22:03 [TG3]: Fix link problem on Dell's onboard 5906 Michael Chan
2007-05-31 21:50 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070531.145024.52169518.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.