All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bernhard Fischer <rep.dot.nop@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] Ogg and Vorbis patch part 2
Date: Thu, 31 May 2007 23:46:38 +0200	[thread overview]
Message-ID: <20070531214638.GE12010@aon.at> (raw)
In-Reply-To: <465F19D0.6020001@teamboyce.co.uk>

On Thu, May 31, 2007 at 07:54:08PM +0100, Rod Boyce wrote:
>
>>just
>>	-$(MAKE) -C $(LIBOGG_WORKDIR) clean
>>and drop the if.
>>[snip]
>>
>>  
>
>All,
>
>Attached is a new improved patch to add libvorbis and libogg to build 
>root.  I have only tested on 386 hopefully others can test on other 
>platforms.  I have a floating point unit so I do not need to use an 
>integer only version.

Thanks for the update, but please see below..
>
>Regards,
>Rod Boyce
>

>diff -uN --recursive ../trunk/package/libogg/libogg.mk package/libogg/libogg.mk
>--- ../trunk/package/libogg/libogg.mk	1970-01-01 01:00:00.000000000 +0100
>+++ package/libogg/libogg.mk	2007-05-31 19:48:23.186662591 +0100
>@@ -0,0 +1,64 @@
+$(LIBVORBIS_DIR)/.unpacked: $(DL_DIR)/$(LIBVORBIS_SOURCE)
+       $(LIBVORBIS_CAT) $(DL_DIR)/$(LIBVORBIS_SOURCE) | tar -C $(BUILD_DIR) $(TAR_OPTIONS) -
+       touch $@

missing CONFIG_UPDATE

[snip]
>+
>+libogg-clean:
>+	@if [ -d $(LIBOGG_DIR)/Makefile ] ; then \
>+		$(MAKE) -C $(LIBOGG_DIR) clean ; \
>+	fi;

just
	-$(MAKE) -C $(LIBOGG_DIR) clean
and drop the if.

>diff -uN --recursive ../trunk/package/libogg/libogg.mk~ package/libogg/libogg.mk~
>--- ../trunk/package/libogg/libogg.mk~	1970-01-01 01:00:00.000000000 +0100
>+++ package/libogg/libogg.mk~	2007-05-31 19:37:14.848508875 +0100

you want --exclude='*~'
Alternatively, a simple "svn diff > ~/mypatch.diff" should do the right
thing.

[snip]
>+
>+libogg-clean:
>+	@if [ -d $(LIBOGG_DIR)/Makefile ] ; then \
>+		$(MAKE) -C $(LIBOGG_DIR) clean ; \
>+	fi;

just
	-$(MAKE) -C $(LIBOGG_DIR) clean
and drop the if.

>+
>+libogg-dirclean:
>+	rm -rf $(LIBOGG_DIR) $(LIBOGG_DIR)
>+#############################################################
>+#
>+# Toplevel Makefile options
>+#
>+#############################################################
>+ifeq ($(strip $(BR2_PACKAGE_LIBOGG)),y)
>+TARGETS+=libogg
>+endif

>diff -uN --recursive ../trunk/package/libvorbis/libvorbis.mk package/libvorbis/libvorbis.mk
>--- ../trunk/package/libvorbis/libvorbis.mk	1970-01-01 01:00:00.000000000 +0100
>+++ package/libvorbis/libvorbis.mk	2007-05-31 19:48:51.409340059 +0100
>@@ -0,0 +1,78 @@
[]
>+$(DL_DIR)/$(LIBVORBIS_SOURCE):
>+	$(WGET) -P $(DL_DIR) $(LIBVORBIS_SITE)/$(LIBVORBIS_SOURCE)
>+
>+$(LIBVORBIS_DIR)/.unpacked: $(DL_DIR)/$(LIBVORBIS_SOURCE)
>+	$(LIBVORBIS_CAT) $(DL_DIR)/$(LIBVORBIS_SOURCE) | tar -C $(BUILD_DIR) $(TAR_OPTIONS) -

missing CONFIG_UPDATE

>+	touch $@
>+

>+libvorbis-clean:
>+	@if [ -d $(LIBVORBIS_DIR)/Makefile ] ; then \
>+		$(MAKE) -C $(LIBVORBIS_DIR) clean ; \
>+	fi;

just
	-$(MAKE) -C $(LIBVORBIS_DIR) clean
and drop the if. 
>+
>+libvorbis-dirclean:
>+	rm -rf $(LIBVORBIS_DIR) $(LIBVORBIS_DIR)
>+
>+
>+#############################################################
>+#
>+# Toplevel Makefile options
>+#
>+#############################################################
>+ifeq ($(strip $(BR2_PACKAGE_LIBVORBIS)),y)
>+TARGETS+=libvorbis
>+endif
>diff -uN --recursive ../trunk/package/libvorbis/libvorbis.mk~ package/libvorbis/libvorbis.mk~
>--- ../trunk/package/libvorbis/libvorbis.mk~	1970-01-01 01:00:00.000000000 +0100
>+++ package/libvorbis/libvorbis.mk~	2007-05-31 07:06:11.547658783 +0100

you want --exclude='*~'
Alternatively, a simple "svn diff > ~/mypatch.diff" should do the right
thing.

  reply	other threads:[~2007-05-31 21:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-28 13:22 [Buildroot] Ogg and Vorbis patch Rod Boyce
2007-05-29 20:25 ` Bernhard Fischer
2007-05-31 18:54   ` [Buildroot] Ogg and Vorbis patch part 2 Rod Boyce
2007-05-31 21:46     ` Bernhard Fischer [this message]
2007-06-01 10:28       ` [Buildroot] Ogg and Vorbis patch part 2.1 Rod Boyce
2007-06-01 11:33         ` Peter Korsgaard
2007-06-01 17:49           ` [Buildroot] SVN diff was " Rod Boyce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070531214638.GE12010@aon.at \
    --to=rep.dot.nop@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.