From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [patch 2.6.22-rc3-git] SPI dynamic busid generation bugfix Date: Fri, 1 Jun 2007 16:33:39 -0700 Message-ID: <20070601163339.482e2327.akpm@linux-foundation.org> References: <200706011612.19766.david-b@pacbell.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: David Brownell Return-path: In-Reply-To: <200706011612.19766.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Fri, 1 Jun 2007 16:12:19 -0700 David Brownell wrote: > Fix SPI dynamic bus ID assignment to start at 2^15-1 rather than > a negative number. Valid bus ids are supposed to be positive, > and are (now) stored in an 's16' value. > > Signed-off-by: David Brownell > > --- a/drivers/spi/spi.c > +++ b/drivers/spi/spi.c > @@ -411,7 +411,7 @@ EXPORT_SYMBOL_GPL(spi_alloc_master); > */ > int spi_register_master(struct spi_master *master) > { > - static atomic_t dyn_bus_id = ATOMIC_INIT((1<<16) - 1); > + static atomic_t dyn_bus_id = ATOMIC_INIT((1<<15) - 1); > struct device *dev = master->cdev.dev; > int status = -ENODEV; > int dynamic = 0; Is this going to underflow then malfunction after 32k modprobe+rmmods? ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/