From: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
To: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [patch 2.6.22-rc3-git] SPI dynamic busid generation bugfix
Date: Fri, 1 Jun 2007 16:53:01 -0700 [thread overview]
Message-ID: <20070601165301.6896b299.akpm@linux-foundation.org> (raw)
In-Reply-To: <200706011646.12340.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
On Fri, 1 Jun 2007 16:46:12 -0700
David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org> wrote:
> On Friday 01 June 2007, Andrew Morton wrote:
> >
> > Is this going to underflow then malfunction after 32k modprobe+rmmods?
>
> Yes. A better fix will be needed, for the crazy people amongst us.
> Dynamic busids are quite uncommon though, so that's not pressing.
lib/idr.c can be used for this. There are patches in Greg's driver
tree which make it better-suited.
The give-me-a-unique-integer thing is so common that we really should
have a wrapper around idr which does just that.
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
prev parent reply other threads:[~2007-06-01 23:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-01 23:12 [patch 2.6.22-rc3-git] SPI dynamic busid generation bugfix David Brownell
[not found] ` <200706011612.19766.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2007-06-01 23:33 ` Andrew Morton
[not found] ` <20070601163339.482e2327.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2007-06-01 23:46 ` David Brownell
[not found] ` <200706011646.12340.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2007-06-01 23:53 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070601165301.6896b299.akpm@linux-foundation.org \
--to=akpm-de/tnxtf+jlsfhdxvbkv3wd2fqjk+8+b@public.gmane.org \
--cc=david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org \
--cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.