From: Andi Kleen <andi@firstfloor.org>
To: Rik van Riel <riel@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>,
Christoph Hellwig <hch@infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
andrew.vasquez@qlogic.com
Subject: Re: [PATCH] quiet down swiotlb warnings
Date: Fri, 1 Jun 2007 21:47:34 +0200 [thread overview]
Message-ID: <20070601194734.GJ7217@one.firstfloor.org> (raw)
In-Reply-To: <466075D1.8080807@redhat.com>
On Fri, Jun 01, 2007 at 03:38:57PM -0400, Rik van Riel wrote:
> Andi Kleen wrote:
>
> >An pci_map_sg failing typically leads to an IO error and we've
> >always printk'ed those. Otherwise people will wonder why they
> >get EIO.
>
> In some situations. In this case the qla2xxx driver uses
> the pci_map_sg() failure as a throttling mechanism and
First WTF does it need swiotlb anyways? QA hardware should
be definitely DAC capable, shouldn't it?
> printing out all the warnings will actually slow down the
> system.
Another reason is that there is a lot of code that
still doesn't check the return values and when that
happens you might get data corruption too.
>
> Andi, what do you propose as a solution?
A different interface; like I wrote in my earlier mail.
Another probabibility would be to have a blocking interface
to swiotlb that won't fail. That would be the better solution
long term, but i was told it is hard to fit into some current
driver interfaces.
-Andi
next prev parent reply other threads:[~2007-06-01 19:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-01 17:30 [PATCH] quiet down swiotlb warnings Rik van Riel
2007-06-01 19:01 ` Andi Kleen
2007-06-01 18:12 ` Christoph Hellwig
2007-06-01 18:18 ` Rik van Riel
2007-06-01 19:37 ` Andi Kleen
2007-06-01 19:38 ` Rik van Riel
2007-06-01 19:47 ` Andi Kleen [this message]
2007-06-01 20:00 ` Andrew Vasquez
2007-06-01 20:14 ` Andi Kleen
2007-06-01 20:20 ` Rik van Riel
2007-06-01 20:26 ` Andi Kleen
2007-06-02 15:21 ` Muli Ben-Yehuda
2007-06-02 16:47 ` Andi Kleen
2007-06-01 19:57 ` Christoph Hellwig
2007-06-01 18:16 ` Andrew Vasquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070601194734.GJ7217@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=andrew.vasquez@qlogic.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.