From: "Ismail Dönmez" <ismail@pardus.org.tr>
To: Junio C Hamano <junkio@cox.net>
Cc: Alexandre Julliard <julliard@winehq.org>,
git@vger.kernel.org, Jakub Narebski <jnareb@gmail.com>
Subject: Re: [PATCH] gitweb: use decode_utf8 directly
Date: Fri, 1 Jun 2007 22:47:52 +0300 [thread overview]
Message-ID: <200706012247.57273.ismail@pardus.org.tr> (raw)
In-Reply-To: <7vr6ovzcgr.fsf@assigned-by-dhcp.cox.net>
[-- Attachment #1: Type: text/plain, Size: 589 bytes --]
On Friday 01 June 2007 22:44:36 Junio C Hamano wrote:
> Alexandre Julliard <julliard@winehq.org> writes:
> > Sorry for the late nack, but it turns out that this patch breaks diff
> > output on the Wine server for files that are not utf-8.
> >
> > The cause is apparently that decode_utf8() returns undef for invalid
> > sequences instead of substituting a replacement char like
> > decode("utf8") does.
>
> Thanks for noticing. Will revert.
Why are reverting a correct bugfix? :( He's at most using outdated software.
*sigh*
/ismail
--
Perfect is the enemy of good
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 827 bytes --]
next prev parent reply other threads:[~2007-06-01 19:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-24 14:05 [PATCH] gitweb: use decode_utf8 directly Ismail Dönmez
2007-04-27 8:55 ` Ismail Dönmez
2007-04-27 9:07 ` Junio C Hamano
2007-04-27 9:22 ` Ismail Dönmez
2007-04-27 19:29 ` Junio C Hamano
2007-05-01 21:12 ` Ismail Dönmez
2007-05-01 21:39 ` Junio C Hamano
2007-05-01 21:44 ` Ismail Dönmez
2007-05-01 21:48 ` Ismail Dönmez
2007-05-03 19:22 ` Ismail Dönmez
2007-05-03 19:26 ` Junio C Hamano
2007-06-01 13:45 ` Alexandre Julliard
2007-06-01 13:50 ` Ismail Dönmez
2007-06-01 16:51 ` Alexandre Julliard
2007-06-01 19:44 ` Junio C Hamano
2007-06-01 19:47 ` Ismail Dönmez [this message]
2007-06-01 20:00 ` Junio C Hamano
2007-06-01 20:08 ` Ismail Dönmez
2007-06-03 22:06 ` Junio C Hamano
2007-06-03 22:13 ` Ismail Dönmez
2007-06-02 8:22 ` Jakub Narebski
-- strict thread matches above, loose matches on Subject: below --
2007-06-01 16:13 Martin Koegler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706012247.57273.ismail@pardus.org.tr \
--to=ismail@pardus.org.tr \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=julliard@winehq.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.