From: Andi Drebes <lists-receive@programmierforen.de>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] Why keeping lines commented out via #if 0?
Date: Sat, 02 Jun 2007 18:31:08 +0000 [thread overview]
Message-ID: <200706022031.08856.lists-receive@programmierforen.de> (raw)
In-Reply-To: <200706021359.23564.lists-receive@programmierforen.de>
<snip>
> > Unless you're willing to go through each one, and figure out whether
> > it's still useful or not for anyone reading this section of code
> > later, it's better to leave it alone.
>
> it's not clear that andi was suggesting a single, sweeping deletion
> operation (which *would* be a bad idea). when i read his post, *i*
> interpreted it as suggesting that a gradual examination might be in
> order, and stuff that was clearly worthless could be removed bit by
> bit.
<snip>
To clarify that affair: No, I didn't want to write a big patch that removes
those lines. I just aked for a reason why those lines should be kept in
the tree. Even if I had not asked why, I wouldn't have written such a patch.
Instead I would have inspected these lines in detail (which is btw what I'm
going to do whenever I encounter such lines in the future).
Perhaps I picked up the wrong list. Maybe I should have asked that on
the kernel-newbie mailing list.
I'm sorry this conversation got that emotional. I didn't want to bring you
to that point (please remember: it was just a *question*).
Cheers,
Andi
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2007-06-02 18:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-02 11:59 [KJ] Why keeping lines commented out via #if 0? Andi Drebes
2007-06-02 13:15 ` Robert P. J. Day
2007-06-02 14:59 ` Matthew Wilcox
2007-06-02 15:29 ` Robert P. J. Day
2007-06-02 15:47 ` Matthew Wilcox
2007-06-02 16:48 ` Robert P. J. Day
2007-06-02 18:00 ` Andi Drebes
2007-06-02 18:13 ` Arnaldo Carvalho de Melo
2007-06-02 18:31 ` Andi Drebes [this message]
2007-06-02 18:47 ` Thomas De Schampheleire
2007-06-03 8:09 ` Robert P. J. Day
2007-06-03 9:12 ` Rene Herman
2007-06-03 10:47 ` Andi Drebes
2007-07-02 10:43 ` Vegard Nossum
2007-07-02 11:07 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706022031.08856.lists-receive@programmierforen.de \
--to=lists-receive@programmierforen.de \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.