From: Stephen Hemminger <shemminger@linux-foundation.org>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, jeff@garzik.org
Subject: Re: doubt about qla3xxx checksum "fix"
Date: Sun, 3 Jun 2007 18:50:59 -0700 [thread overview]
Message-ID: <20070603185059.7f1e76cd@freepuppy> (raw)
In-Reply-To: <20070603.180051.89019554.davem@davemloft.net>
On Sun, 03 Jun 2007 18:00:51 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
>
> I don't think it's %100 right, I'm referring specifically to
>
> e68a8c10c4c5daf363e946d10c1a5cba77d7f92c
>
> Sure, qla3xxx is only handling ipv4 in that ql_hw_csum_setup()
> function, but if you check the call site it really wants
> CHECKSUM_PARTIAL skb's to work on. And CHECKSUM_PARTIAL skbs are only
> setup for paths that advertise the NETIF_F_HW_CSUM capability.
CHECKSUM_PARTIAL is used on xmit for both NETIF_F_HWCSUM and NETIF_F_IPCSUM
See acenic, 3c59x, ...
--
Stephen Hemminger <shemminger@linux-foundation.org>
next prev parent reply other threads:[~2007-06-04 2:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-04 1:00 doubt about qla3xxx checksum "fix" David Miller
2007-06-04 1:50 ` Stephen Hemminger [this message]
2007-06-04 2:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070603185059.7f1e76cd@freepuppy \
--to=shemminger@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.