All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: David Chinner <dgc@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: TAKE 965636 - xfs_setfilesize panics on null xfs_inode
Date: Mon, 4 Jun 2007 09:52:29 +0100	[thread overview]
Message-ID: <20070604085229.GA17635@infradead.org> (raw)
In-Reply-To: <20070604084608.GW85884050@sgi.com>

On Mon, Jun 04, 2007 at 06:46:08PM +1000, David Chinner wrote:
> On Mon, Jun 04, 2007 at 09:32:22AM +0100, Christoph Hellwig wrote:
> > On Mon, Jun 04, 2007 at 06:28:12PM +1000, David Chinner wrote:
> > > Handle null returned from xfs_vtoi() in xfs_setfilesize().
> > 
> > This doesn't make any sense at all.  xfs_inodes always live longer than
> > vnodes.  What's the backtrace of the problem you're seeing?
> 
> The I/O completion handlers are used by CXFS clients as well.
> Hence we can't assume that the vnode is backed by a xfs_inode....

Please switch them over to something different instead of crapping up
the code like this

      reply	other threads:[~2007-06-04  8:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-04  8:28 TAKE 965636 - xfs_setfilesize panics on null xfs_inode David Chinner
2007-06-04  8:32 ` Christoph Hellwig
2007-06-04  8:46   ` David Chinner
2007-06-04  8:52     ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070604085229.GA17635@infradead.org \
    --to=hch@infradead.org \
    --cc=dgc@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.