From: Adrian Bunk <bunk@stusta.de>
To: Nitin Gupta <nitingupta910@gmail.com>
Cc: Richard Purdie <rpurdie@openedhand.com>,
Daniel Hazelton <dhazelton@enter.net>,
akpm <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Hugh Dickins <hugh@veritas.com>,
Nick Piggin <nickpiggin@yahoo.com.au>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH -mm 0/5] LZO and swap write failure patches for -mm
Date: Mon, 4 Jun 2007 22:06:06 +0200 [thread overview]
Message-ID: <20070604200606.GA5500@stusta.de> (raw)
In-Reply-To: <4cefeab80706041126y5f12402cl61b72ec101dd7915@mail.gmail.com>
On Mon, Jun 04, 2007 at 11:56:46PM +0530, Nitin Gupta wrote:
> On 6/4/07, Richard Purdie <rpurdie@openedhand.com> wrote:
>...
>> The zlib code isn't kernel style and is arguably bloated, perhaps we
>> should remove that?
>
> I don't know - I don't use zlib.
> We can make LZO cleaner and perhaps faster. This will be good.
>...
"cleaner" = much harder to upgrade to new upstream LZO versions -> bad
"perhaps faster" = different from the well-known original code and
might again contain new bugs -> bad
"perhaps faster" = if we fork LZO and actually get it faster, all the
other LZO users will not benefit -> bad
zlib and LZO are special because they are maintained userspace code
imported into the kernel.
> Regards,
> Nitin
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2007-06-04 20:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-04 15:36 [PATCH -mm 0/5] LZO and swap write failure patches for -mm Richard Purdie
2007-06-04 16:14 ` Daniel Hazelton
2007-06-04 16:52 ` Richard Purdie
2007-06-04 17:37 ` Daniel Hazelton
2007-06-04 18:34 ` Nitin Gupta
2007-06-04 20:45 ` Richard Purdie
2007-06-04 22:13 ` Daniel Hazelton
2007-06-04 18:26 ` Nitin Gupta
2007-06-04 20:06 ` Adrian Bunk [this message]
2007-06-05 5:30 ` Nitin Gupta
2007-06-05 5:50 ` Andrew Morton
2007-06-05 8:56 ` Richard Purdie
2007-06-04 20:58 ` Richard Purdie
2007-06-05 6:15 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070604200606.GA5500@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@linux-foundation.org \
--cc=dhazelton@enter.net \
--cc=dwmw2@infradead.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=nitingupta910@gmail.com \
--cc=rpurdie@openedhand.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.