All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bernhard Fischer <rep.dot.nop@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] Update to mpg123
Date: Mon, 4 Jun 2007 23:04:06 +0200	[thread overview]
Message-ID: <20070604210406.GF2853@aon.at> (raw)
In-Reply-To: <46647757.6030306@teamboyce.co.uk>

On Mon, Jun 04, 2007 at 09:34:31PM +0100, Rod Boyce wrote:
>Peter Korsgaard wrote:
>>Thanks - A few commments:
>>
>>RB> -MPG123_VERSION=0.59r
>>RB> +MPG123_VERSION := 0.65
>>
>>In the mean time 0.66 got released.
>>
>>RB> -MPG123_SOURCE=mpg123-$(MPG123_VERSION).tar.gz
>>RB> -MPG123_CAT:=$(ZCAT)
>>RB> -MPG123_SITE=http://www.mpg123.de/mpg123
>>RB> -MPG123_DIR=$(BUILD_DIR)/mpg123-$(MPG123_VERSION)
>>RB> +MPG123_SOURCE := mpg123-$(MPG123_VERSION).tar.bz2
>>RB> +MPG123_CAT := $(BZCAT)
>>RB> +MPG123_SITE := http://www.mpg123.de/download
>>RB> +MPG123_DIR := $(BUILD_DIR)/mpg123-$(MPG123_VERSION)
>>
>>What's with all those white space changes? Could you please send an
>>updated patch without those and with the version bumped to 0.66?
>>  
>Peter & All,
>
>Attached is another mpg123 patch with the version number bumped to 
>TODAY's new released version number.  I have made no other changes to 
>this patch is considering the changes I had to make for the previous 
>version so minor which space changes are more than allowable in my 
>opinion.  You are welcome to submit your own change that makes the code 
>harder to read, but I'll stay with a few more spaces and a slightly 
>prettier looking makefile fragment.

We are asking you, politely, to adhere to the established style of
*not* using spaces there, once again.

There is no sensible argument for makeing the sources bigger and less
readable in my eyes.

>Regards,
>Rod Boyce

      reply	other threads:[~2007-06-04 21:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-02 13:02 [Buildroot] Update to mpg123 Rod Boyce
2007-06-04  9:04 ` Peter Korsgaard
2007-06-04 20:34   ` Rod Boyce
2007-06-04 21:04     ` Bernhard Fischer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070604210406.GF2853@aon.at \
    --to=rep.dot.nop@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.