Re: [RFC/PATCH 4/4] Add support for MSI on Axon-based Cell systems

[Jean-Christophe Dubois <jdubois@mc.com>]

On Monday 04 June 2007 15:00:05 Michael Ellerman wrote:
> +=A0=A0=A0=A0=A0=A0=A0pr_debug("axon_msi: initialising ...\n");
> +
> +=A0=A0=A0=A0=A0=A0=A0for_each_compatible_node(node, NULL, "ibm,axon-msic=
") {
> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0if (axon_msi_setup_one(of_n=
ode_get(node)) =3D=3D 0)
> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0fou=
nd++;
> +=A0=A0=A0=A0=A0=A0=A0}
> +=A0=A0=A0=A0=A0=A0=A0of_node_put(node);

2 comments:

1) There is no "ibm,axon-msic" compatible property in the SLOF tree provide=
d=20
by IBM on the CAB (or other such platforms). Therefore this code will not=20
work on these platforms.

2) you should somehow check for the Axon version. Axon 1.1 (and prior) are=
=20
know to be loosing MSI/MBX interrupts (but not the data part associated to=
=20
them). Therefore this should be enabled only on Axon 2.1 (or later).

JC