Re: [PATCH] Leave GPIO[7:6] pullups enabled.

[Tony Lindgren <tony@atomide.com>]

* Felipe Balbi <felipebalbi@users.sourceforge.net> [070529 05:04]:
> From: Felipe Balbi <felipe.lima@indt.org.br>
> 
> GPIO7 and GPIO6 are configured as default wake-up sources for
> tusb6010.
> 
> without this patch MUSB is not able to enumerate
> any device that draw power from it.
> 
> After applying this patch, we're passing in almost
> all OTG Electrical Tests.
> 
> Signed-off-by: Felipe Balbi <felipe.lima@indt.org.br>
> ---
> 
> Index: linux-omap-2.6/drivers/usb/musb/tusb6010.c
> ===================================================================
> --- linux-omap-2.6.orig/drivers/usb/musb/tusb6010.c	2007-05-28 13:18:46.000000000 +0300
> +++ linux-omap-2.6/drivers/usb/musb/tusb6010.c	2007-05-28 13:26:28.000000000 +0300
> @@ -879,8 +879,11 @@
>  {
>  	void __iomem	*base = musb->ctrl_base;
>  
> -	/* Disable GPIO[7:0] pullups (used as output DMA requests) */
> -	musb_writel(base, TUSB_PULLUP_1_CTRL, 0x000000FF);
> +	/* GPIO[7:6] are the default wake-up sources for tusb6010.
> +	 * We cannot disable their pullups.
> +	 *
> +	 * Disable GPIO[5:0] pullups (used as output DMA requests) */
> +	musb_writel(base, TUSB_PULLUP_1_CTRL, 0x0000003F);
>  	/* Disable all pullups on NOR IF, DMAREQ0 and DMAREQ1 */
>  	musb_writel(base, TUSB_PULLUP_2_CTRL, 0x01FFFFFF);
>  

Pushing this one today, I edited the comments a bit.

Tony