All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] for loops and variable declarations...
Date: Tue, 05 Jun 2007 12:23:06 +0000	[thread overview]
Message-ID: <20070605122306.GD8605@parisc-linux.org> (raw)
In-Reply-To: <ab8e556c0706050422y1cf091a8n34313317a92a5afd@mail.gmail.com>

On Tue, Jun 05, 2007 at 07:59:19AM -0400, John Anthony Kazos Jr. wrote:
> This is 2007. C99 is not "new" and anybody writing new code designed for 
> an earlier version of C is certainly hopped up on crack at the very least.

Yes, we're all hopped up on crack.

> A second valid point is that the Linux kernel requires not only the GNU 
> CC, but a relatively recent GNU CC, and someone trying to use any other 
> compiler with it is recommended to have fun banging their head against the 
> wall. Especially since there are many (yes, MANY) places in the code that 
> not only use C99+GNU-only constructs, but in fact use pure GNU-only 
> extensions which have been discussed and approved several times on this 
> list.
> 
> The time is long past to even joke about supporting any compiler other 
> than GCC. If -c99 isn't in the CFLAGS by now, it needs to be.

Actually, this is explicitly forbidden in the Linux kernel:

# warn about C99 declaration after statement
CFLAGS += $(call cc-option,-Wdeclaration-after-statement,)

Just because it's supported by the compiler, and permitted by a
standard, doesn't make it good CodingStyle.

Speaking of CodingStyle, the original poster should see
Documentation/CodingStyle chapter 6 for why this isn't a problem.
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

  parent reply	other threads:[~2007-06-05 12:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-05 11:22 [KJ] for loops and variable declarations Kevin Jackson
2007-06-05 11:37 ` Pierre Habouzit
2007-06-05 11:59 ` John Anthony Kazos Jr.
2007-06-05 12:23 ` Matthew Wilcox [this message]
2007-06-05 13:07 ` Robert P. J. Day

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070605122306.GD8605@parisc-linux.org \
    --to=matthew@wil.cx \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.