From: wysochanski@sourceware.org <wysochanski@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2/tools pvdisplay.c
Date: 5 Jun 2007 18:23:18 -0000 [thread overview]
Message-ID: <20070605182318.32172.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: wysochanski at sourceware.org 2007-06-05 18:23:18
Modified files:
tools : pvdisplay.c
Log message:
make code consistent with pvresize code - good candidate for common code cleanup
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/pvdisplay.c.diff?cvsroot=lvm2&r1=1.27&r2=1.28
--- LVM2/tools/pvdisplay.c 2007/05/31 20:10:25 1.27
+++ LVM2/tools/pvdisplay.c 2007/06/05 18:23:17 1.28
@@ -19,10 +19,10 @@
struct volume_group *vg __attribute((unused)),
struct physical_volume *pv, void *handle)
{
+ struct pv_list *pvl;
int consistent = 0;
int ret = ECMD_PROCESSED;
uint64_t size;
- struct physical_volume *pv_temp;
const char *pv_name = dev_name(pv->dev);
@@ -49,15 +49,14 @@
* Replace possibly incomplete PV structure with new one
* allocated in vg_read() path.
*/
- pv_temp = find_pv(vg, pv->dev);
- if (!pv_temp) {
- log_error("Unable to find physical volume %s "
- "in volume group %s",
- pv_name, pv->vg_name);
+ if (!(pvl = find_pv_in_vg(vg, pv_name))) {
+ log_error("Unable to find \"%s\" in volume group \"%s\"",
+ pv_name, vg->name);
ret = ECMD_FAILED;
- goto out;
+ goto out;
}
- pv = pv_temp;
+
+ pv = pvl->pv;
}
if (!*pv->vg_name)
reply other threads:[~2007-06-05 18:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070605182318.32172.qmail@sourceware.org \
--to=wysochanski@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.