[U-Boot-Users] [PATCH] Added support for multiple serial for MPC8XX

[Stefan Roese <sr@denx.de>]

Hi Stefano,

On Wednesday 06 June 2007, Wolfgang Denk wrote:
> > However, I didn't want to have two different coding styles with different
> > meaning inside the same file. In fact, some lines later the whole mess of
> > #ifdef was already inserted for the ppc4xx architecture using
> > CONFIG_CONS_INDEX to switch among the interfaces.
>
> Please feel free to clean this up the same was as I suggested. I'm
> sure Stefan Roese will ACK such a change.
>
> We should get rid of all this CONFIG_CONS_INDEX stuff.

Yes, please. I'll be happy to test on 4xx hardware, if you have a patch 
removing this maze. Thanks.

> > I didn't want to change this part because this would break all ppc4xx
> > boards that are not part of the U-Boot tree. So I preferred to add a lot
> > of #ifdef using the same CONFIG defines as in ppc4xx instead of creating
> > a new one.
>
> I'm afraid I don't understand what you mean. Usually  we  don't  care
> about boards that are not part of the U-Boot tree.

Right. It's impossible to support the non official board ports. Sometimes we 
have to make changes that *can* break inofficial code.

> > I will resend the patch with the modifications for the mpc8xx, without
> > touching ppc4xx part. This would not break any custom board.
>
> Please feel free to fix it for the existing 4xx boards as well. I'd
> really appreciate this, and I even volunteer to test it on a few of
> them.

No need to. I'll do it.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================