From: Stephen Rothwell <git@ozlabs.org>
To: Josh Triplett <josh@freedesktop.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Remove useless uses of cat, and replace with filename arguments or redirection
Date: Wed, 6 Jun 2007 13:39:15 +1000 [thread overview]
Message-ID: <20070606133915.d72e4afe.git@ozlabs.org> (raw)
In-Reply-To: <46660F43.4060402@freedesktop.org>
[-- Attachment #1: Type: text/plain, Size: 289 bytes --]
On Tue, 05 Jun 2007 18:34:59 -0700 Josh Triplett <josh@freedesktop.org> wrote:
>
> -commits=$(cat ../revs | wc -l | tr -d " ")
> +commits=$(wc -l ../revs | tr -d " ")
This is not equivalent, you probably wanted:
commits=$(wc -l <../revs | tr -d " ")
Cheers,
Stephen Rothwell
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-06-06 3:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-06 1:34 [PATCH] Remove useless uses of cat, and replace with filename arguments or redirection Josh Triplett
2007-06-06 3:39 ` Stephen Rothwell [this message]
2007-06-06 3:51 ` Michael Poole
2007-06-06 3:58 ` Martin Langhoff
2007-06-06 4:54 ` Stephen Rothwell
2007-06-06 6:38 ` Martin Langhoff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070606133915.d72e4afe.git@ozlabs.org \
--to=git@ozlabs.org \
--cc=git@vger.kernel.org \
--cc=josh@freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.