From: Arnd Bergmann <arnd@arndb.de>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] of_serial: ignore unknown serial port
Date: Wed, 6 Jun 2007 15:01:15 +0200 [thread overview]
Message-ID: <200706061501.15853.arnd@arndb.de> (raw)
In-Reply-To: <fe647387a21ec103882e7cf577d0d7d5@kernel.crashing.org>
On Wednesday 06 June 2007, Segher Boessenkool wrote:
> >
> > Is this a bugfix that needs to go in 2.6.22?
>
> This potentially breaks lots of other platforms, so no
> please, put it in early in the next cycle and give those
> others time to recover from this change.
I would expect that the bugfix is relatively harmless, as the
driver is rather new and there can only be a very small set
of users. All the OF based systems should be working fine
either way, because they already have legacy_serial, and
the dtc sources that come with the kernel all list the
serial ports as compatible to either "ns16550", "cpm_uart",
"marvell,mpsc", or "mpc5200-psc-uart". In the first case
of those four, the change is harmless, for the other three
it is a valid bug fix.
It probably only makes a difference for 52xx in the case that
you have CONFIG_SERIAL_OF_PLATFORM=y and CONFIG_SERIAL_MPC52xx=m.
In that configuration, you get the same bug that Kou Ishizaki
observed on celleb without this fix.
Arnd <><
next prev parent reply other threads:[~2007-06-06 13:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-31 9:30 [PATCH] of_serial: ignore unknown serial port Ishizaki Kou
2007-05-31 10:46 ` Arnd Bergmann
2007-06-06 5:58 ` Paul Mackerras
2007-06-06 9:09 ` Segher Boessenkool
2007-06-06 13:01 ` Arnd Bergmann [this message]
2007-06-06 13:44 ` Segher Boessenkool
2007-06-06 9:28 ` kouish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706061501.15853.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.