From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amin Azez Subject: RE: xt_gateway 20070605 (kernel) Date: Wed, 6 Jun 2007 16:58:43 +0100 Message-ID: <200706061718.l56HIjv08406@server1.secure-linux-server.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: Netfilter Developer Mailing List , Amin Azez To: Patrick McHardy , Jan Engelhardt Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: netfilter-devel-bounces@lists.netfilter.org Errors-To: netfilter-devel-bounces@lists.netfilter.org List-Id: netfilter-devel.vger.kernel.org So is it necessary to resubmit the kernel patch with the un-necessary match= es turned into explanatory comments? Sam -----Original Message----- From: "Patrick McHardy" To: "Jan Engelhardt" Cc: "Netfilter Developer Mailing List" ; "Amin Azez" Sent: 06/06/07 12:31 Subject: Re: xt_gateway 20070605 (kernel) Jan Engelhardt wrote: > On Jun 5 2007 17:15, Patrick McHardy wrote: >=20 >>Most of the checks here are unnecessary anyway (we always >>have a skb with skb->dst !=3D NULL, neigh->tbl is always !=3D NULL >>and the neighbour table family is always AF_INET since the >>match is only registered for AF_INET. >=20 >=20 > Thanks for letting us now. Now, prime question: Is skb always !=3D NULL? > (Otherwise it would not really make sense calling the match if > there was nothing to match.) Yes.