All of lore.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: Shaohua Li <shaohua.li@intel.com>
Cc: linux acpi <linux-acpi@vger.kernel.org>, Adam Belay <abelay@novell.com>
Subject: Re: [patch] Hook acpi D-state method to pnp suspend/resume
Date: Wed, 6 Jun 2007 21:55:41 -0400	[thread overview]
Message-ID: <200706062155.41912.lenb@kernel.org> (raw)
In-Reply-To: <1180665425.27219.5.camel@sli10-conroe.sh.intel.com>

On Thursday 31 May 2007 22:37, Shaohua Li wrote:

I like this patch, it may save power while in S3...
I gather that it should also automatically expose the D-state controls
for these PNP devices in sysfs, which may come in very handy...

> +static int pnpacpi_suspend(struct pnp_dev *dev, pm_message_t state)
> +{
> +       return acpi_bus_set_power((acpi_handle)dev->data, 3);
> +}
> +

This should usually work, but...
If the device is enabled as a wakeup device, this could
disable its wakeup capability.

So in that case, we need to check _S3W to make sure that
we are not putting the device in a D-state deeper than
it can still wake the system.

-Len
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2007-06-07  1:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-01  2:37 [patch] Hook acpi D-state method to pnp suspend/resume Shaohua Li
2007-06-07  1:55 ` Len Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200706062155.41912.lenb@kernel.org \
    --to=lenb@kernel.org \
    --cc=abelay@novell.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=shaohua.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.