From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>, hpoussin@reactos.org
Subject: Re: [Qemu-devel] [PATCH] Add parallel memory mapped interface
Date: Wed, 6 Jun 2007 23:36:28 +0100 [thread overview]
Message-ID: <200706062336.29722.paul@codesourcery.com> (raw)
In-Reply-To: <f43fc5580706061314l203d03b5qb969a4a226bfef32@mail.gmail.com>
On Wednesday 06 June 2007, Blue Swirl wrote:
> On 6/6/07, Hervé Poussineau <hpoussin@reactos.org> wrote:
> > Hi,
> >
> > This patch adds a memory-mapped interface to the parallel port emulation.
> > It is not as complete as I/O interface (no EPP/ECP), but I didn't want to
> > add lots of code for very little use.
> > It also cleans up indentation of the file (replaces tabulations by four
> > spaces)
IMHO it's a bad idea to combine writespace cleanups with actual changes.
It makes the patch much larger and more confusing than it needs to be.
> Please don't use target_ulong in device drivers, but
> target_phys_addr_t for physical addresses. I don't know about IO
> addresses, uint32_t?
"int" is appropriate for IO port addresses.
This is what the register_ioport_{read,write} routines use.
Paul
prev parent reply other threads:[~2007-06-06 22:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-06 19:26 [Qemu-devel] [PATCH] Add parallel memory mapped interface Hervé Poussineau
2007-06-06 20:14 ` Blue Swirl
2007-06-06 22:36 ` Paul Brook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706062336.29722.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=blauwirbel@gmail.com \
--cc=hpoussin@reactos.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.