Re: 2.6.22-rc4-mm1

[WANG Cong <xiyou.wangcong@gmail.com>]

On Thu, Jun 07, 2007 at 12:59:13AM -0500, Matt Mackall wrote:
>On Thu, Jun 07, 2007 at 10:26:09AM +0800, WANG Cong wrote:
>> On Wed, Jun 06, 2007 at 11:09:31AM -0700, Andrew Morton wrote:
>> >On Thu, 7 Jun 2007 00:19:36 +0800 WANG Cong <xiyou.wangcong@gmail.com> wrote:
>> >
>> >> On Wed, Jun 06, 2007 at 02:07:37AM -0700, Andrew Morton wrote:
>> >> >
>> >> >ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm1/
>> >> >
>> >> >- Somebody broke it on my powerpc G5, but I didn't have time to do yet
>> >> >  another bisection yet.
>> >> >
>> >> 
>> >> It seems strange that a new C source file (mlguest.c) appears in the top dir of the 
>> >> kernel source. There are some problems with it.
>> >> 
>> >> First, I used `make mlguest.o` to compile that file, but I got tons of warnings and errors.
>> >> (Too many to put here.) What's wrong with it? Or I didn't compile/configure it correctly?
>> >> 
>> >> Second, mlguest.c #includes a head file named "../../include/linux/lguest_launcher.h".
>> >> Since mlguest.c is in the top dir, so where is ../../include/linux/lguest_launcher.h?
>> >> 
>> >
>> >Confused.  I've grepped the entire universe here for "mlguest" and came up
>> >with nothing.
>> >
>> >I don't have a clue where that file came from on your system.
>> 
>> 
>> I used 'ketchup' to update my kernel from -rc3 to -rc4-mm1. I got the follow:
>> 
>> [wangcong@localhost linux-2.6.22-rc4-mm1]$ ls
>> arch     Documentation  ipc          Makefile        README          System.map
>> block    drivers        Kbuild       mlguest.c       REPORTING-BUGS  usr
>> COPYING  fs             kernel       mm              scripts         vmlinux
>> CREDITS  include        lib          Module.symvers  security
>> crypto   init           MAINTAINERS  net             sound
>> 
>> Maybe there's something wrong with ketchup. ;(
>
>Can you do an 'lsdiff | grep lguest' on the patch in your ~/.ketchup directory?
>
>Ketchup simply applies patches, it never touches filenames directly.
>So for something to go wrong here and drop a file in the tree with a
>damaged pathname, you've either got a damaged patch, a bug in patch
>itself, or some form of filesystem corruption.

Thanks for your point.

It should be Documentation/lguest/lguest.c, maybe it was corrupted and ketchup
backuped it as mlguest.c.

Sorry for this.