Re: [PATCH] fsck: do not crash on tag objects which do not contain an empty line

[Johan Herland <johan@herland.net>]

On Friday 08 June 2007, Nicolas Pitre wrote:
> On Fri, 8 Jun 2007, Johan Herland wrote:
> 
> > I agree that we should fail gracefully, and my code is clearly not doing 
> > that in this case. My bad.
> > 
> > But the code should also detect invalid tag objects, and in this case I'm 
> > not yet convinced that the tag object causing the failure is in fact valid. 
> > If someone can convince me that the blank line after headers is optional, 
> > then I'll gladly fix the code.
> 
> That's irrelevant.
> 
> Because you are fed invalid data is no excuse for crashing.
> 
> Especially in a tool like fsck, you should _expect_ and cope with 
> invalid data. That's why it exists in the first place: to identify such
> data.

Of course. If you read my first sentence in the quote above, you will see
that I agree with you 100%.


...Johan

-- 
Johan Herland, <johan@herland.net>
www.herland.net