From: Tony Lindgren <tony@atomide.com>
To: Kevin Hilman <khilman@mvista.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] ARM: OMAP: 2430SDP: minor fixups for fb driver
Date: Fri, 8 Jun 2007 03:28:07 -0700 [thread overview]
Message-ID: <20070608102806.GK28556@atomide.com> (raw)
In-Reply-To: <11810916333338-git-send-email-khilman@mvista.com>
* Kevin Hilman <khilman@mvista.com> [070605 18:04]:
> Remove redundant #defines
> Fix LCD pixelclock to 5.4 MHz
>
> Signed-off-by: Hunyue Yau <hyau@mvista.com>
> Signed-off-by: Kevin Hilman <khilman@mvista.com>
> ---
> drivers/video/omap/lcd_2430sdp.c | 8 ++------
> 1 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/video/omap/lcd_2430sdp.c b/drivers/video/omap/lcd_2430sdp.c
> index 0c50d10..6e5b603 100644
> --- a/drivers/video/omap/lcd_2430sdp.c
> +++ b/drivers/video/omap/lcd_2430sdp.c
> @@ -31,14 +31,10 @@
>
> #define LCD_PANEL_BACKLIGHT_GPIO 91
> #define LCD_PANEL_ENABLE_GPIO 154
> -#define H4_LCD_PIXCLOCK_MAX 185186 /* freq 5.4 MHz */
> +#define LCD_PIXCLOCK_MAX 5400 /* freq 5.4 MHz */
> #define PM_RECEIVER TWL4030_MODULE_PM_RECIEVER
> #define ENABLE_VAUX2_DEDICATED 0x09
> #define ENABLE_VAUX2_DEV_GRP 0x20
> -#define TWL4030_VAUX2_DEV_GRP 0x1B
> -#define TWL4030_VAUX2_DEDICATED 0x1E
> -#define TWL4030_MODULE_PM_RECIEVER 0x13
> -
>
>
> #define t2_out(c, r, v) twl4030_i2c_write_u8(c, r, v)
> @@ -99,7 +95,7 @@ struct lcd_panel sdp2430_panel = {
> .vfp = 2, /* lower_margin */
> .vbp = 7, /* upper_margin (8) - 1 */
>
> - .pixel_clock = H4_LCD_PIXCLOCK_MAX,
> + .pixel_clock = LCD_PIXCLOCK_MAX,
>
> .init = sdp2430_panel_init,
> .cleanup = sdp2430_panel_cleanup,
Pushing today.
Tony
next prev parent reply other threads:[~2007-06-08 10:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-06 1:00 [PATCH] ARM: OMAP: compile fix for CONFIG_PM_DEBUG=y Kevin Hilman
2007-06-06 1:00 ` [PATCH] ARM: OMAP: 2430 PM: emul_ck is only available on 242x Kevin Hilman
2007-06-08 10:26 ` Tony Lindgren
2007-06-06 1:00 ` [PATCH] ARM: OMAP: init section mismatch for omap2/timer-gp Kevin Hilman
2007-06-06 1:43 ` Nishanth Menon
2007-06-06 1:00 ` [PATCH] ARM: OMAP: 2430SDP: minor fixups for fb driver Kevin Hilman
2007-06-08 10:28 ` Tony Lindgren [this message]
2007-06-08 10:26 ` [PATCH] ARM: OMAP: compile fix for CONFIG_PM_DEBUG=y Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070608102806.GK28556@atomide.com \
--to=tony@atomide.com \
--cc=khilman@mvista.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.