All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: andrzej zaborowski <balrogg@gmail.com>
Cc: Linux OMAP <linux-omap-open-source@linux.omap.com>
Subject: Re: [PATCH] ARM: OMAP: Fix omap1510-generic board compilation.
Date: Fri, 8 Jun 2007 03:31:26 -0700	[thread overview]
Message-ID: <20070608103126.GM28556@atomide.com> (raw)
In-Reply-To: <fb249edb0706061945n20d12010scf13154d981c0657@mail.gmail.com>

* andrzej zaborowski <balrogg@gmail.com> [070606 19:46]:
> Move an #endif so that it doesn't hide the mmc config declaration.
> Minor formatting change.
>
> Signed-off-by: Andrzej Zaborowski <balrog@zabor.org>

> From d0ec40c4888e8d0281ae38abd5de4caba5adfc3f Mon Sep 17 00:00:00 2001
> From: Andrzej Zaborowski <balrog@zabor.org>
> Date: Thu, 7 Jun 2007 05:26:43 +0200
> Subject: [PATCH] ARM: OMAP: Fix omap1510-generic building out of defconfig.
> 
> ---
>  arch/arm/mach-omap1/board-generic.c |    7 +++----
>  1 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/mach-omap1/board-generic.c b/arch/arm/mach-omap1/board-generic.c
> index 33d01ad..29fa364 100644
> --- a/arch/arm/mach-omap1/board-generic.c
> +++ b/arch/arm/mach-omap1/board-generic.c
> @@ -55,6 +55,7 @@ static struct omap_usb_config generic1610_usb_config __initdata = {
>  	.hmc_mode	= 16,
>  	.pins[0]	= 6,
>  };
> +#endif
>  
>  static struct omap_mmc_config generic_mmc_config __initdata = {
>  	.mmc [0] = {
> @@ -73,15 +74,13 @@ static struct omap_mmc_config generic_mmc_config __initdata = {
>  	},
>  };
>  
> -#endif
> -
>  static struct omap_uart_config generic_uart_config __initdata = {
>  	.enabled_uarts = ((1 << 0) | (1 << 1) | (1 << 2)),
>  };
>  
>  static struct omap_board_config_kernel generic_config[] = {
> -	{ OMAP_TAG_USB,           NULL },
> -	{ OMAP_TAG_MMC,           &generic_mmc_config },
> +	{ OMAP_TAG_USB,		NULL },
> +	{ OMAP_TAG_MMC,		&generic_mmc_config },
>  	{ OMAP_TAG_UART,	&generic_uart_config },
>  };
>  

This one does not seem to apply, did you forget to send your patch
0006 that this depends on?

Tony

  reply	other threads:[~2007-06-08 10:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-07  2:45 [PATCH] ARM: OMAP: Fix omap1510-generic board compilation andrzej zaborowski
2007-06-08 10:31 ` Tony Lindgren [this message]
2007-06-10 11:52   ` andrzej zaborowski
2007-06-12 18:32     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070608103126.GM28556@atomide.com \
    --to=tony@atomide.com \
    --cc=balrogg@gmail.com \
    --cc=linux-omap-open-source@linux.omap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.