From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] libata: claim ctl port for legacy SFF ports
Date: Fri, 8 Jun 2007 10:24:37 -0400 [thread overview]
Message-ID: <20070608142437.GA25649@havoc.gtf.org> (raw)
In-Reply-To: <466963B1.4070208@gmail.com>
On Fri, Jun 08, 2007 at 11:12:01PM +0900, Tejun Heo wrote:
> Jeff Garzik wrote:
> > On Fri, Jun 08, 2007 at 08:41:19PM +0900, Tejun Heo wrote:
> >> libata used to claim only cmd ports for legacy SFF ports. Claim ctl
> >> ports too.
> >>
> >> Signed-off-by: Tejun Heo <htejun@gmail.com>
> >> ---
> >> This has been this way as long as I can remember. It's almost
> >> pleasant to see that it survived through all the devres/init rework.
> >> I guess it's time for a change.
> >
> > pci_request_regions() should claims everything, if Alan did his job :)
> >
> > All this goes through ata_pci_init_one(), which guarantees it's PCI IDE.
>
> Allowing legacy to be used on non-PCI systems was your idea! Alright,
> then we can drop a lot of junk from legacy SFF code. Will prep another
> patch. Please ignore two patches in this thread.
Alan seems to be ignoring that idea, so it turned out to be useless... :/
Jeff
next prev parent reply other threads:[~2007-06-08 14:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-04 23:51 legacy libata IDE missing reservation Jeff Garzik
2007-06-08 11:41 ` [PATCH] libata: claim ctl port for legacy SFF ports Tejun Heo
2007-06-08 11:51 ` Alan Cox
2007-06-08 12:01 ` Tejun Heo
2007-06-08 12:30 ` [PATCH] libata: claim legacy SFF ctl ioport in legacy_dr Tejun Heo
2007-06-08 12:50 ` [PATCH] libata: claim ctl port for legacy SFF ports Alan Cox
2007-06-08 13:55 ` Jeff Garzik
2007-06-08 14:12 ` Tejun Heo
2007-06-08 14:24 ` Jeff Garzik [this message]
2007-06-08 15:33 ` Alan Cox
2007-06-08 15:36 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070608142437.GA25649@havoc.gtf.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.