From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1HwjJY-0004FL-DK
	for qemu-devel@nongnu.org; Fri, 08 Jun 2007 14:36:00 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1HwjJX-0004Ej-6t
	for qemu-devel@nongnu.org; Fri, 08 Jun 2007 14:35:59 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1HwjJX-0004Ed-2h
	for qemu-devel@nongnu.org; Fri, 08 Jun 2007 14:35:59 -0400
Received: from phoenix.bawue.net ([193.7.176.60] helo=mail.bawue.net)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <ths@networkno.de>) id 1HwjJW-0002F7-Sf
	for qemu-devel@nongnu.org; Fri, 08 Jun 2007 14:35:59 -0400
Date: Fri, 8 Jun 2007 19:35:56 +0100
Subject: Re: [Qemu-devel] Sparc32 network problems
Message-ID: <20070608183556.GG26587@networkno.de>
References: <F2989D33-960B-4F79-95CC-CE9E83EA2A32@web.de>
	<5C0D359E-F154-4E86-8BCF-72EBF9A27EEA@web.de>
	<f43fc5580706061127l1625f6abi9f2cd6a54a5f3811@mail.gmail.com>
	<E5CB9135-BBD0-411D-AC00-C73B49D509CF@web.de>
	<f43fc5580706071259q356d4d0dh545fa26481500627@mail.gmail.com>
	<20070607210431.GB26587@networkno.de>
	<56EFBCEE-69E1-451E-B025-31D2D600B867@web.de>
	<f43fc5580706080925j523f4b26wcdf60a0fb16a0bec@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f43fc5580706080925j523f4b26wcdf60a0fb16a0bec@mail.gmail.com>
From: Thiemo Seufer <ths@networkno.de>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org

Blue Swirl wrote:
[snip]
> >I haven't been able to test the new patch yet.
> >
> >Q's patch and my adaptation for tcx just reversed the order of the
> >colors, just like BlueSwirl's patch except that they used #if
> >__LITTLE_ENDIAN__ in place of #ifdef WORDS_BIGENDIAN, and this worked
> >for both i386 and sparc32 guests on i386 host (but is not applied for
> >ppc host).
> >
> >http://www.kju-app.org/proj/browser/trunk/patches/q_vga.c_02.diff
> 
> I think this is not correct either, instead the DisplayState bgr
> attribute should be used. This version should work like before, and on
> BGR displays the colours should be correct. VGA needs a similar change
> for 15 and 16 bit depths if I'm correct.

This one doesn't change anything for my testcases, so I guess it
is ok for me.


Thiemo