From: Venki Pallipadi <venkatesh.pallipadi@intel.com>
To: Len Brown <len.brown@intel.com>
Cc: Robert Moore <robert.moore@intel.com>, linux-acpi@vger.kernel.org
Subject: [PATCH] check xpm2_control_block while setting bm_control
Date: Fri, 8 Jun 2007 13:25:37 -0700 [thread overview]
Message-ID: <20070608202537.GA2184@linux-os.sc.intel.com> (raw)
Check both pm2_control_block and cpm2_control_block for bm_control. It should
be better to do this with checking of address from consolidated
fadt_info_table[]. But, that will need some changes in acpica tables code.
Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Index: linux-2.6.22-rc-mm/drivers/acpi/processor_core.c
===================================================================
--- linux-2.6.22-rc-mm.orig/drivers/acpi/processor_core.c 2007-06-07 11:03:56.000000000 -0700
+++ linux-2.6.22-rc-mm/drivers/acpi/processor_core.c 2007-06-07 11:20:53.000000000 -0700
@@ -521,11 +521,22 @@
acpi_processor_errata(pr);
+ if (acpi_gbl_FADT.header.revision >= FADT2_REVISION_ID) {
+ /* FADT rev. 2 */
+ if (acpi_gbl_FADT.xpm_timer_block.space_id !=
+ ACPI_ADR_SPACE_SYSTEM_IO)
/*
* Check to see if we have bus mastering arbitration control. This
* is required for proper C3 usage (to maintain cache coherency).
+ * Check both pm2_control_block and xpm2_control_block
*/
- if (acpi_gbl_FADT.pm2_control_block && acpi_gbl_FADT.pm2_control_length) {
+ if ((acpi_gbl_FADT.header.revision >= FADT2_REVISION_ID &&
+ acpi_gbl_FADT.xpm2_control_block.space_id ==
+ ACPI_ADR_SPACE_SYSTEM_IO &&
+ acpi_gbl_FADT.xpm2_control_block.address &&
+ acpi_gbl_FADT.xpm2_control_block.bit_width) ||
+ (acpi_gbl_FADT.pm2_control_block &&
+ acpi_gbl_FADT.pm2_control_length)) {
pr->flags.bm_control = 1;
ACPI_DEBUG_PRINT((ACPI_DB_INFO,
"Bus mastering arbitration control present\n"));
next reply other threads:[~2007-06-08 20:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-08 20:25 Venki Pallipadi [this message]
2007-06-08 22:09 ` [PATCH] check xpm2_control_block while setting bm_control Pallipadi, Venkatesh
2007-06-08 22:16 ` Venki Pallipadi
2007-07-19 1:54 ` Brown, Len
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070608202537.GA2184@linux-os.sc.intel.com \
--to=venkatesh.pallipadi@intel.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.