From: acripps <acripps@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] [PATCH 2/4] 2.6 drivers/net lp46e replace SIZE macros
Date: Sat, 09 Jun 2007 03:01:53 +0000 [thread overview]
Message-ID: <20070609031353.14624.16332.sendpatchset@localhost.localdomain> (raw)
Replaced SIZE(x) macro with the more descriptive ARRAY_SIZE(arr) macro
defined in kernel.h
Also removed 22 lines of code that will never be compiled because of
preprocessor directive: #if 0
compile tested, no compile time issues found.
Signed-off-by: Aaron Cripps <cripps@cs.mun.ca>
diff -Nuar linux-2.6/drivers/net/lp486e.c linux-2.6-patched/drivers/net/lp486e.c
--- linux-2.6/drivers/net/lp486e.c 2007-05-22 20:31:03.000000000 -0230
+++ linux-2.6-patched/drivers/net/lp486e.c 2007-05-25 22:43:16.000000000 -0230
@@ -515,33 +515,6 @@
outb(0, IOADDR+8);
}
-#define SIZE(x) (sizeof(x)/sizeof((x)[0]))
-
-#if 0
-/* selftest or dump */
-static void
-i596_port_do(struct net_device *dev, int portcmd, char *cmdname) {
- struct i596_private *lp = dev->priv;
- u16 *outp;
- int i, m;
-
- memset((void *)&(lp->dump), 0, sizeof(struct i596_dump));
- outp = &(lp->dump.dump[0]);
-
- PORT(va_to_pa(outp), portcmd);
- mdelay(30); /* random, unmotivated */
-
- printk("lp486e i82596 %s result:\n", cmdname);
- for (m = SIZE(lp->dump.dump); m && lp->dump.dump[m-1] = 0; m--)
- ;
- for (i = 0; i < m; i++) {
- printk(" %04x", lp->dump.dump[i]);
- if (i%8 = 7)
- printk("\n");
- }
- printk("\n");
-}
-#endif
static int
i596_scp_setup(struct net_device *dev) {
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
next reply other threads:[~2007-06-09 3:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-09 3:01 acripps [this message]
2007-06-09 6:23 ` [KJ] [PATCH 2/4] 2.6 drivers/net lp46e replace SIZE macros Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070609031353.14624.16332.sendpatchset@localhost.localdomain \
--to=acripps@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.