Re: 2.6.22-rc2 built on ppc (1)

[Pavel Machek <pavel@ucw.cz>]

Hi!

> > > kernel/power/swsusp.c: In function 'swsusp_show_speed':
> > > kernel/power/swsusp.c:193: warning: comparison of distinct pointer types lacks a cast
> > 
> > Well, this warning doesn't make sense.  In 2.6.22-rc2 line 193 of swsusp.c is
> > 
> > do_div(elapsed_centisecs64, NSEC_PER_SEC / 100);
> > 
> > where elapsed_centisecs64 is s64.
> 
> yeah, and the do_div64 macro is then comparing (s64*) == (u64*) in a
> null-statement and tells you that the types are different. I tracked
> this a long time ago and figured it wasn't worth thinking about.

Elimar, can you modify the code to 

do_div(elapsed_centisecs64, (s64) NSEC_PER_SEC / 100);

...to see if the warning goes away?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html