From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1HxJaG-0000eI-0a for mharc-grub-devel@gnu.org; Sun, 10 Jun 2007 05:19:40 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HxJaF-0000e4-1F for grub-devel@gnu.org; Sun, 10 Jun 2007 05:19:39 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HxJaD-0000dm-MT for grub-devel@gnu.org; Sun, 10 Jun 2007 05:19:37 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HxJaD-0000dh-HV for grub-devel@gnu.org; Sun, 10 Jun 2007 05:19:37 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HxJaD-0007HQ-CK for grub-devel@gnu.org; Sun, 10 Jun 2007 05:19:37 -0400 Received: from tschwinge by fencepost.gnu.org with local (Exim 4.60) (envelope-from ) id 1HxJaD-0000p8-3o; Sun, 10 Jun 2007 05:19:37 -0400 Date: Sun, 10 Jun 2007 11:19:37 +0200 From: Thomas Schwinge To: Marco Gerards Message-ID: <20070610091937.GE29831@fencepost.gnu.org> References: <20070609045616.GA9839@ws3.vdp.com> <87645x2ebq.fsf@xs4all.nl> <20070610034253.GA617@ws3.vdp.com> <87y7is1bt3.fsf@xs4all.nl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qFgkTsE6LiHkLPZw" Content-Disposition: inline In-Reply-To: <87y7is1bt3.fsf@xs4all.nl> X-Homepage: http://nic-nac-project.de/~schwinge/ User-Agent: Mutt/1.5.11 X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) Cc: The development of GRUB 2 Subject: Re: Update for NTFS file system driver X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Jun 2007 09:19:39 -0000 --qFgkTsE6LiHkLPZw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello! On Sun, Jun 10, 2007 at 09:57:44AM +0200, Marco Gerards wrote: > Bean writes: > > On Sat, Jun 09, 2007 at 08:05:45PM +0200, Marco Gerards wrote: > >> The normal procedure for patches is to make them consistent with the > >> GCS (GNU Coding Standards), include a changelog. That way it is > >> easier to review the patch and to include it in GRUB 2. >=20 > The GNU Coding Standards: > http://www.gnu.org/prep/standards/standards.html >=20 > The specific part on ChangeLog entries: > http://www.gnu.org/prep/standards/standards.html#Change-Logs >=20 > The biggest part is on indentation, etc. Sorry, but that is also the part which the upstream committers (e.g. you, or me, or some more others) can trivially fix if you don't like it the way the first-time contributor has done. That's my idea of this eternal ``your-formatting-only-does-stop-us-from-committing-your-patch'' thing. And that is also what I would expect if I were a first-time contributor. Otherwise I might decide to spend my time elsewhere. Regards, Thomas --qFgkTsE6LiHkLPZw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.2 (GNU/Linux) iD8DBQFGa8Ipgfzh735dTTURApcOAKCIEtRT3GyTHQVsM9DeIG/XoSDpSgCfWo2r iaU2AF5oPW3Lpm4cAcMxWC0= =HEvn -----END PGP SIGNATURE----- --qFgkTsE6LiHkLPZw--