From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1HxP8M-0004DE-8a for mharc-grub-devel@gnu.org; Sun, 10 Jun 2007 11:15:14 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HxP8K-0004D9-SJ for grub-devel@gnu.org; Sun, 10 Jun 2007 11:15:12 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HxP8I-0004Cx-JC for grub-devel@gnu.org; Sun, 10 Jun 2007 11:15:12 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HxP8I-0004Cu-Gb for grub-devel@gnu.org; Sun, 10 Jun 2007 11:15:10 -0400 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HxP8H-0000mh-6i for grub-devel@gnu.org; Sun, 10 Jun 2007 11:15:09 -0400 Received: from [192.168.10.6] (helo=aragorn) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1HxP8F-0003Vr-1E for grub-devel@gnu.org; Sun, 10 Jun 2007 17:15:08 +0200 Received: from rmh by aragorn with local (Exim 4.63) (envelope-from ) id 1HxP8z-0000kE-FG for grub-devel@gnu.org; Sun, 10 Jun 2007 17:15:53 +0200 Date: Sun, 10 Jun 2007 17:15:53 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20070610151553.GA2640@aragorn> References: <20070609045616.GA9839@ws3.vdp.com> <87645x2ebq.fsf@xs4all.nl> <20070610034253.GA617@ws3.vdp.com> <87y7is1bt3.fsf@xs4all.nl> <20070610120329.GA782@ws3.vdp.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="jRHKVT23PllUwdXP" Content-Disposition: inline In-Reply-To: <20070610120329.GA782@ws3.vdp.com> Organization: free as in freedom X-Message-Flag: Microsoft discourages use of Outlook. X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: Genre and OS details not recognized. Subject: Re: Update for NTFS file system driver X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Jun 2007 15:15:13 -0000 --jRHKVT23PllUwdXP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline I noticed that your patch isn't adding ntfs to the utils (grub-probe, etc). I'm attaching a fix for that. ChangeLog entries: * conf/powerpc-ieee1275.rmk: Add fs/ntfs.c to grub-probe and grub-emu. * conf/i386-efi.rmk: Likewise. Also remove unused grub-setup definition. * conf/i386-pc.rmk: Add fs/ntfs.c to grub-probe, grub-emu and grub-setup. On Sun, Jun 10, 2007 at 08:03:29PM +0800, Bean wrote: > Ok, I reformat the patch, hopefully it will conform to standard. I think what Marco meant is a multipart/mixed attachment (like the one I'm sending now). This is what most mail programs do when you attach a text file (but not a gzipped one!). The good thing about this method, is that you can easily extract a patch (without copy-pasting or being exposed to unwanted format conversions), but the patch is still part of the message so you can reply to it to discuss specific parts, keeping their context. -- Robert Millan My spam trap is honeypot@aybabtu.com. Note: this address is only intended for spam harvesters. Writing to it will get you added to my black list. --jRHKVT23PllUwdXP Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="add_ntfs_to_utils.diff" * conf/powerpc-ieee1275.rmk: Add fs/ntfs.c to grub-probe and grub-emu. * conf/i386-efi.rmk: Likewise. Also remove unused grub-setup definition. * conf/i386-pc.rmk: Add fs/ntfs.c to grub-probe, grub-emu and grub-setup. diff -ur grub2.old/conf/i386-efi.rmk grub2/conf/i386-efi.rmk --- grub2.old/conf/i386-efi.rmk 2007-06-04 21:48:53.000000000 +0200 +++ grub2/conf/i386-efi.rmk 2007-06-10 17:03:39.000000000 +0200 @@ -15,14 +15,6 @@ grub_mkimage_SOURCES = util/i386/efi/grub-mkimage.c util/misc.c \ util/resolve.c -# For grub-setup. -#grub_setup_SOURCES = util/i386/pc/grub-setup.c util/i386/pc/biosdisk.c \ -# util/misc.c util/i386/pc/getroot.c kern/device.c kern/disk.c \ -# kern/err.c kern/misc.c fs/fat.c fs/ext2.c fs/xfs.c fs/affs.c \ -# fs/sfs.c kern/parser.c kern/partition.c partmap/pc.c \ -# fs/ufs.c fs/minix.c fs/hfs.c fs/jfs.c fs/hfsplus.c kern/file.c \ -# kern/fs.c kern/env.c fs/fshelp.c - # For grub-mkdevicemap. grub_mkdevicemap_SOURCES = util/grub-mkdevicemap.c util/misc.c @@ -32,7 +24,7 @@ kern/device.c kern/disk.c kern/err.c kern/misc.c fs/fat.c \ fs/ext2.c kern/parser.c kern/partition.c \ partmap/pc.c partmap/apple.c partmap/gpt.c \ - fs/ufs.c fs/minix.c fs/hfs.c fs/jfs.c kern/fs.c \ + fs/ufs.c fs/minix.c fs/hfs.c fs/jfs.c fs/ntfs.c kern/fs.c \ kern/env.c fs/fshelp.c fs/xfs.c fs/affs.c fs/sfs.c fs/hfsplus.c \ disk/lvm.c disk/raid.c @@ -48,6 +40,7 @@ disk/loopback.c \ fs/affs.c fs/ext2.c fs/fat.c fs/fshelp.c fs/hfs.c fs/iso9660.c \ fs/jfs.c fs/minix.c fs/sfs.c fs/ufs.c fs/xfs.c fs/hfsplus.c \ + fs/ntfs.c \ io/gzio.c \ kern/device.c kern/disk.c kern/dl.c kern/elf.c kern/env.c \ kern/err.c \ diff -ur grub2.old/conf/i386-pc.rmk grub2/conf/i386-pc.rmk --- grub2.old/conf/i386-pc.rmk 2007-06-04 21:48:53.000000000 +0200 +++ grub2/conf/i386-pc.rmk 2007-06-10 17:02:38.000000000 +0200 @@ -67,7 +67,8 @@ kern/err.c kern/misc.c fs/fat.c fs/ext2.c fs/xfs.c fs/affs.c \ fs/sfs.c kern/parser.c kern/partition.c partmap/pc.c \ partmap/gpt.c fs/ufs.c fs/minix.c fs/hfs.c fs/jfs.c \ - fs/hfsplus.c kern/file.c kern/fs.c kern/env.c fs/fshelp.c \ + fs/hfsplus.c fs/ntfs.c kern/file.c kern/fs.c kern/env.c \ + fs/fshelp.c \ util/raid.c util/lvm.c # For grub-mkdevicemap. @@ -79,7 +80,7 @@ kern/device.c kern/disk.c kern/err.c kern/misc.c fs/fat.c \ fs/ext2.c kern/parser.c kern/partition.c \ partmap/pc.c partmap/apple.c partmap/gpt.c \ - fs/ufs.c fs/minix.c fs/hfs.c fs/jfs.c kern/fs.c \ + fs/ufs.c fs/minix.c fs/hfs.c fs/jfs.c fs/ntfs.c kern/fs.c \ kern/env.c fs/fshelp.c fs/xfs.c fs/affs.c fs/sfs.c fs/hfsplus.c \ disk/lvm.c disk/raid.c @@ -95,6 +96,7 @@ disk/loopback.c disk/raid.c disk/lvm.c \ fs/affs.c fs/ext2.c fs/fat.c fs/fshelp.c fs/hfs.c fs/iso9660.c \ fs/jfs.c fs/minix.c fs/sfs.c fs/ufs.c fs/xfs.c fs/hfsplus.c \ + fs/ntfs.c \ io/gzio.c \ kern/device.c kern/disk.c kern/dl.c kern/elf.c kern/env.c \ kern/err.c \ diff -ur grub2.old/conf/powerpc-ieee1275.rmk grub2/conf/powerpc-ieee1275.rmk --- grub2.old/conf/powerpc-ieee1275.rmk 2007-06-04 21:48:53.000000000 +0200 +++ grub2/conf/powerpc-ieee1275.rmk 2007-06-10 17:04:01.000000000 +0200 @@ -44,7 +44,7 @@ kern/device.c kern/disk.c kern/err.c kern/misc.c fs/fat.c \ fs/ext2.c kern/parser.c kern/partition.c \ partmap/pc.c partmap/apple.c partmap/gpt.c \ - fs/ufs.c fs/minix.c fs/hfs.c fs/jfs.c kern/fs.c \ + fs/ufs.c fs/minix.c fs/hfs.c fs/jfs.c fs/ntfs.c kern/fs.c \ kern/env.c fs/fshelp.c fs/xfs.c fs/affs.c fs/sfs.c fs/hfsplus.c \ disk/lvm.c disk/raid.c @@ -59,6 +59,7 @@ disk/loopback.c \ fs/affs.c fs/ext2.c fs/fat.c fs/fshelp.c fs/hfs.c fs/iso9660.c \ fs/jfs.c fs/minix.c fs/sfs.c fs/ufs.c fs/xfs.c fs/hfsplus.c \ + fs/ntfs.c \ io/gzio.c \ kern/device.c kern/disk.c kern/dl.c kern/elf.c kern/env.c \ kern/err.c kern/file.c kern/fs.c kern/loader.c kern/main.c \ --jRHKVT23PllUwdXP--