From: "John W. Linville" <linville@tuxdriver.com>
To: Michael Wu <flamingice@sourmilk.net>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Jiri Benc <jbenc@suse.cz>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH V3] mac80211: Set low initial rate in rc80211_simple
Date: Mon, 11 Jun 2007 14:43:27 -0400 [thread overview]
Message-ID: <20070611184327.GE10397@tuxdriver.com> (raw)
In-Reply-To: <200706111111.11547.flamingice@sourmilk.net>
On Mon, Jun 11, 2007 at 11:11:07AM -0700, Michael Wu wrote:
> On Monday 11 June 2007 10:31, John W. Linville wrote:
> > How about "I think you forgot some curly braces"? Until Johannes
> > posted his patch (which you could have done just as easily) I had no
> > idea what you were talking about here...
> >
> Well, I did end up explaining it later after it was obvious that Larry Finger
> didn't understand what I mean.
Nothing says it like a patch...
> As for posting a patch to fix it? I figured Larry Finger would post a fixed
> patch after I explained the comment. I didn't think you were going to merge
> it.
I put it in wireless-dev -- I might ask to be forgiven, if I thought
that was a problem.
Are you satisfied with that patch as it stands now (i.e. w/ the
proper braces)? Or do you want to peck at it some more?
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2007-06-11 18:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-08 3:03 [PATCH V3] mac80211: Set low initial rate in rc80211_simple Larry Finger
2007-06-08 3:38 ` Michael Wu
2007-06-08 3:49 ` Larry Finger
2007-06-08 5:05 ` Michael Wu
2007-06-08 9:21 ` Jiri Benc
2007-06-08 14:58 ` Jouni Malinen
2007-06-08 18:12 ` Luis R. Rodriguez
2007-06-08 18:34 ` Jouni Malinen
2007-06-08 20:10 ` Luis R. Rodriguez
2007-06-08 21:45 ` Jouni Malinen
2007-06-08 16:35 ` Michael Wu
2007-06-11 17:31 ` John W. Linville
2007-06-11 18:11 ` Michael Wu
2007-06-11 18:43 ` John W. Linville [this message]
2007-06-11 19:09 ` Michael Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070611184327.GE10397@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=Larry.Finger@lwfinger.net \
--cc=flamingice@sourmilk.net \
--cc=jbenc@suse.cz \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.