From: "John W. Linville" <linville@tuxdriver.com>
To: davem@davemloft.net
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH] cfg80211: fix signed macaddress in sysfs
Date: Mon, 11 Jun 2007 21:17:16 -0400 [thread overview]
Message-ID: <20070612011716.GD20422@tuxdriver.com> (raw)
In-Reply-To: <20070612011616.GC20422@tuxdriver.com>
From: David Lamparter <lists@diac24.net>
Fix signedness mixup making mac addresses show up strangely
(like 00:11:22:33:44:ffffffaa) in /sys/class/ieee80211/*/macaddress.
Signed-off-by: David Lamparter <equinox@diac24.net>
Acked-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
net/wireless/sysfs.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/wireless/sysfs.c b/net/wireless/sysfs.c
index 3ebae14..88aaacd 100644
--- a/net/wireless/sysfs.c
+++ b/net/wireless/sysfs.c
@@ -33,7 +33,7 @@ static ssize_t _show_permaddr(struct device *dev,
struct device_attribute *attr,
char *buf)
{
- char *addr = dev_to_rdev(dev)->wiphy.perm_addr;
+ unsigned char *addr = dev_to_rdev(dev)->wiphy.perm_addr;
return sprintf(buf, "%.2x:%.2x:%.2x:%.2x:%.2x:%.2x\n",
addr[0], addr[1], addr[2], addr[3], addr[4], addr[5]);
--
1.5.0.6
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2007-06-12 1:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-12 1:16 mac80211 fixes for 2.6.22 John W. Linville
2007-06-12 1:17 ` John W. Linville [this message]
2007-06-12 1:18 ` [PATCH] mac80211: fix debugfs tx power reduction output John W. Linville
2007-06-12 1:18 ` [PATCH] mac80211: Don't stop tx queue on master device while scanning John W. Linville
2007-06-12 21:14 ` mac80211 fixes for 2.6.22 David Miller
-- strict thread matches above, loose matches on Subject: below --
2007-06-03 22:06 [PATCH] cfg80211: fix signed macaddress in sysfs David Lamparter
2007-06-04 11:40 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070612011716.GD20422@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=davem@davemloft.net \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.