Re: [PATCH v6][RFC] Fix hugetlb pool allocation with empty nodes

[Nishanth Aravamudan <nacc@us.ibm.com>]

On 11.06.2007 [19:25:08 -0700], Christoph Lameter wrote:
> On Mon, 11 Jun 2007, Christoph Lameter wrote:
> 
> > On Mon, 11 Jun 2007, Nishanth Aravamudan wrote:
> > 
> > > static int nid = first_node(node_populated_map), I get:
> > > 
> > > mm/hugetlb.c:108: error: initializer element is not constant
> > 
> > Remove the static.
> 
> Cutting down the CCs.
> 
> Removing static wont help if the variable is still global. You need to 
> define a local variable. Then it can be initialized with a variable 
> expression.

What global?

nid is static to alloc_fresh_huge_page().

gcc says that the static variable (which *must* be static for the
current round-robin allocation method) cannot be initialized with a
non-constant (which first_node is).

Thanks,
Nish

-- 
Nishanth Aravamudan <nacc@us.ibm.com>
IBM Linux Technology Center

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>