From: William Lee Irwin III <wli@holomorphy.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Adam Litke <agl@us.ibm.com>, dean gaudet <dean@arctic.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
linux-kernel@vger.kernel.org, ak@suse.de, clameter@sgi.com
Subject: Re: [shm][hugetlb] Fix get_policy for stacked shared memory files
Date: Mon, 11 Jun 2007 21:48:55 -0700 [thread overview]
Message-ID: <20070612044855.GD11781@holomorphy.com> (raw)
In-Reply-To: <20070611213020.b3d91757.akpm@linux-foundation.org>
On Mon, Jun 11, 2007 at 09:30:20PM -0700, Andrew Morton wrote:
> Can we just double-check the refcounting please?
The refcounting for mpol's doesn't look good in general. I'm more
curious as to what releases the refcounts. alloc_page_vma(), for
instance, does get_vma_policy() which eventually takes a reference,
without ever releasing the reference it acquires. get_vma_policy()
itself uses a similar idiom to that used in aglitke's patch. I think
mpol refcounting needs to be addressed elsewhere besides this patch.
-- wli
next prev parent reply other threads:[~2007-06-12 4:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-16 5:41 2.6.21 numa policy and huge pages not working dean gaudet
2007-05-16 6:12 ` William Lee Irwin III
2007-06-09 18:06 ` dean gaudet
2007-06-10 4:10 ` dean gaudet
2007-06-10 4:51 ` William Lee Irwin III
2007-06-11 16:23 ` Adam Litke
2007-06-11 21:34 ` [shm][hugetlb] Fix get_policy for stacked shared memory files Adam Litke
2007-06-12 3:36 ` dean gaudet
2007-06-12 3:51 ` William Lee Irwin III
2007-06-12 4:30 ` Andrew Morton
2007-06-12 4:48 ` William Lee Irwin III [this message]
2007-06-12 10:20 ` Andi Kleen
2007-06-12 6:20 ` Eric W. Biederman
2007-06-12 6:58 ` William Lee Irwin III
2007-06-12 14:32 ` Adam Litke
2007-06-12 18:22 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070612044855.GD11781@holomorphy.com \
--to=wli@holomorphy.com \
--cc=agl@us.ibm.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=dean@arctic.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.