From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Brownell Subject: Re: [PATCH] Infineion TLE62X0 device driver Date: Tue, 12 Jun 2007 10:21:25 -0700 Message-ID: <200706121021.25932.david-b@pacbell.net> References: <20070605183244.GE13353@trinity.fluff.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Ben Dooks To: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Return-path: In-Reply-To: <20070605183244.GE13353-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Tuesday 05 June 2007, Ben Dooks wrote: > Add support for the Infineon TLE62x0 series of low-side driver > chips, such as the TLE6220 or TLE6230. I forwarded a version with minor updates/fixes; thanks. Ben, you might consider getting rid of the separate "status" file for diagnostic info and just bundling that with as part of each individual line's status ... it seems odd to view that apart from whether the switch is e.g. on or not, and there are sysfs fascists who object to multi-valued files. Also, it looked to me like the init_state should have been fed to the chip, rather than just assumed to be correct. - Dave ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/