From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Hy7TF-0005xx-JC for mharc-grub-devel@gnu.org; Tue, 12 Jun 2007 10:35:45 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Hy7TE-0005xd-FG for grub-devel@gnu.org; Tue, 12 Jun 2007 10:35:44 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Hy7TD-0005xG-Ms for grub-devel@gnu.org; Tue, 12 Jun 2007 10:35:44 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hy7TD-0005xB-Fa for grub-devel@gnu.org; Tue, 12 Jun 2007 10:35:43 -0400 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Hy7TD-0004B0-4S for grub-devel@gnu.org; Tue, 12 Jun 2007 10:35:43 -0400 Received: from [192.168.10.6] (helo=aragorn) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1Hy7Sm-0000Mi-0q for grub-devel@gnu.org; Tue, 12 Jun 2007 16:35:16 +0200 Received: from rmh by aragorn with local (Exim 4.63) (envelope-from ) id 1Hy7SG-0000pt-8Q for grub-devel@gnu.org; Tue, 12 Jun 2007 16:34:44 +0200 Date: Tue, 12 Jun 2007 16:34:44 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20070612143444.GD1754@aragorn> References: <466E8A36.7000104@raulete.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <466E8A36.7000104@raulete.net> Organization: free as in freedom X-Message-Flag: Microsoft discourages use of Outlook. X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: Genre and OS details not recognized. Subject: Re: Pager does work from a menu? X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jun 2007 14:35:44 -0000 On Tue, Jun 12, 2007 at 01:57:42PM +0200, adrian15 wrote: > This code from: normal/command.c > > /* Enable the pager if the environment pager is set to 1. */ > if (interactive) > pager = grub_env_get ("pager"); > else > pager = 0; > if (pager && (! grub_strcmp (pager, "1"))) > grub_set_more (1); > > Can anyone confirm my suspictions that even the pager variable set to 1 > there is NO stop on the screen when running a grub option that has the > cat command inside it with a big file? Can you ellaborate? From the code you pasted, I just see that when "interactive" is set to 0, this has the same effect as pager being set to the "0" string. (btw, this pager = 0 assignment looks a bit confusing; I changed it to NULL altogether with the other two I spotted earlier) > I am suspecting because in grub legacy there was the same stupid > behaviour which I fixed of course. > > I also do not like the way that pager is run. I mean, putting a getkey > inside the > > void > grub_putcode (grub_uint32_t code) > > function from: kern/term.c > > it seems to me a bit childish although I do not know so far a better > solution. Please try to tear down that language! "stupid" and "childish" are in general not very appropiate words for a development list. I suppose you're referring to: grub_printf ("--MORE--"); grub_setcolorstate (GRUB_TERM_COLOR_STANDARD); key = grub_getkey (); What do you find wrong in this code? AFAICS, the message is printed and then we use grub_getkey to block untill a key is pressed. Sounds like normal pager-ish behaviour to me.. -- Robert Millan My spam trap is honeypot@aybabtu.com. Note: this address is only intended for spam harvesters. Writing to it will get you added to my black list.